950418 - sticky-legend-1.html will be permaorange when 28 merges to beta

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Phil Ringnalda (:philor)]

It's not glaringly obvious why, like most of them are, but as the reftest orange in https://tbpl.mozilla.org/?tree=Try&rev=9e4d891154f4 (current aurora pushed to try as though it had been merged to beta) shows, sticky-legend-1.html is just waiting for ifdef RELEASE_BUILD to be true so it can become permaorange.

Comment 1

[Corey Ford [:coyotebush]]

Looks like that reftest doesn't have the sticky pref enabled. Double-checking the fix now.

Comment 2

[Corey Ford [:coyotebush]]

Attachment: Enable sticky pref for sticky-legend-1.html reftest.

Yep, that was it. (I didn't manage to enable RELEASE_BUILD locally, but confirmed that it fails without this change if I make the pref always false by default.)

Comment 3

[Phil Ringnalda (:philor)]

Just in case you ever need to, the key to RELEASE_BUILD is to take the a1 off the content of config/milestone.txt. 29.0a1 defines NIGHTLY_BUILD, 29.0a2 defines nothing, 29.0 defines RELEASE_BUILD

Comment 4

[Corey Ford [:coyotebush]]

Thanks. Got that to work, and confirmed that this patch does fix the test with RELEASE_BUILD defined.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/37c7fbeb787a
https://hg.mozilla.org/releases/mozilla-aurora/rev/050d4121ba7b

This test was added in bug 931460 and therefore doesn't exist on beta (unsurprisingly since we'd be perma-failing now otherwise).

Comment 6

[Phil Ringnalda (:philor)]

Counting backward isn't one of my specialties.

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/37c7fbeb787a