950447 - mozillabuild incorrectly detects presence of Windows 8.1 SDK when only some of its features installed

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[Phoenix]

In case when I have not full SDK installed, but only some minor features of it (only WinDBG in my case), mozbuild thinks that full SDK is present and prefer it over SDK 7.0.
Problem is in guess-msvc.bat file, it uses
SET SDK80KEY=HKLM\SOFTWARE\Microsoft\Windows Kits\Installed Roots
while it should first check 
HKLM\SOFTWARE\Microsoft\Windows Kits\Installed Products
for Windows Software Development Kit value in keys, and only if it finds it then queue Installed Roots for path

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Just for clarify, this is happening with the 1.9.0 test build?

Comment 2

[Phoenix]

Yes, I just finish deploying all stuff to new server and this is happening on 1.9.0 too. One addition: by default, sdksetup doesn't create those keys in case of installing only debuggers, but if you using standalone .msi installers those keys are creating and confusing mozbuild.

Comment 3

[Makoto Kato [:m_kato]]

(In reply to Phoenix from comment #2)
> Yes, I just finish deploying all stuff to new server and this is happening
> on 1.9.0 too. One addition: by default, sdksetup doesn't create those keys
> in case of installing only debuggers, but if you using standalone .msi
> installers those keys are creating and confusing mozbuild.

phoenix, could you know both GUID for SDK 8.0 and 8.1?

Comment 4

[Makoto Kato [:m_kato]]

{5FB4C443-6BD6-1514-2717-3827D65AE6FB} means 8.0 and {5247E16E-BCF8-95AB-1653-B3F8FBF8B3F1} means 8.1

Comment 5

[Makoto Kato [:m_kato]]

Humm, even if uninstall SDK, registry value into HKLM\SOFTWARE\Microsoft\Windows Kits\Installed Products isn't deleted....

I should check header file (ex. windows.h) finally...

Comment 6

[Makoto Kato [:m_kato]]

Attachment: Use Installed Prodcuts and file check

Comment 7

[Makoto Kato [:m_kato]]

Comment on attachment 8347916 [details] [diff] [review]
Use Installed Prodcuts and file check

registry value into Installed Products key isn't deleted even if uninstalling SDK.  So we check header file also.

Comment 8

[Makoto Kato [:m_kato]]

Comment on attachment 8347916 [details] [diff] [review]
Use Installed Prodcuts and file check

I should check SDKDIR is empty.

Comment 9

[Makoto Kato [:m_kato]]

Attachment: v2

Comment 10

[Makoto Kato [:m_kato]]

Comment on attachment 8351324 [details] [diff] [review]
v2

even if checking registry into HKLM\SOFTWARE\Microsoft\Windows Kits\Installed Products, it isn't enough.  When uninstalling SDK, this key is still existed.  So I need add check header file

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8351324 [details] [diff] [review]
v2

Review of attachment 8351324 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the wording changes

::: guess-msvc.bat
@@ +126,5 @@
>    )
>  )
>  
> +REM Even if uninstall SDK, Installed Products key is still existed.
> +REM If not exist header, we shouldn't detect SDK installation

"The Installed Products key still exists even if the SDK is uninstalled. Verify that the Windows.h header exists to confirm that the SDK is installed."

@@ +142,5 @@
>    )
>  )
>  
> +REM Even if uninstall SDK, Installed Products key is still existed.
> +REM If not exist header, we shouldn't detect SDK installation

Same as above.

Comment 12

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/mozilla-build/rev/6a2f87becc78