Closed
Bug 950450
Opened 12 years ago
Closed 12 years ago
Port | Bug 867957 - Location bar became empty if both web search and prefix/suffix addition disabled | to SeaMonkey
Categories
(SeaMonkey :: Location Bar, defect)
SeaMonkey
Location Bar
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.26
People
(Reporter: mz+bugzilla, Assigned: mz+bugzilla)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.93 KB,
patch
|
mz+bugzilla
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #867957 +++
Attachment #8347718 -
Flags: review?(neil)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 8347718 [details] [diff] [review]
Simple copy patch
>- aFlags & nsIWebProgressListener.LOCATION_CHANGE_ERROR_PAGE)
>+ ((aFlags & nsIWebProgressListener.LOCATION_CHANGE_ERROR_PAGE) &&
You added an extra set of ()s here but they're unnecessary.
>+ aLocation.spec != "about:blank"))
As mentioned in the other patch, the indentation is wrong here. Once you remove the unnecessary ()s above you should align aLocation with aFlags; it should end up looking something like this:
if (this.mBrowser.userTypedClear > 0 ||
(aFlags & nsIWebProgressListener.LOCATION_CHANGE_ERROR_PAGE &&
aLocation.spec != "about:blank"))
Attachment #8347718 -
Flags: review?(neil) → review+
Made mentioned changes, carrying r+
Attachment #8347718 -
Attachment is obsolete: true
Attachment #8349610 -
Flags: review+
Keywords: checkin-needed
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.26
You need to log in
before you can comment on or make changes to this bug.
Description
•