950469 - [Setringtone][l12y] "Set as ringtone" string is reused on title and button

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Théo Chevalier]

When setting a song as a ringtone, the string "Set as ringtone" is used on title and button while it should not.

Comment 1

[Théo Chevalier]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/14676

Comment 2

[David Flanagan [:djf]]

Comment on attachment 8347757 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/14676

This change looks fine to me. 

Are you a localizer, Theo? I don't want to land something that is going to create more work for localizers, but if this patch is needed for localization then please land.  (Or, email me and ask me to land it if you don't have rights.)

Note that the ringtone setting feature is likely to change in 1.4 and become integrated with the ringtone app, so this patch will only be useful if uplifted to 1.3.  Is that intention?

It seems completely risk-free to uplift. But let's only land this if it is actually preventing proper localization.

Comment 3

[Francesco Lodolo [:flod]]

This kind of change is actually helping localizers: titles and buttons have different font size and space available, also some locales use different grammatical structures for each one (nouns in titles, verbs in buttons), so reusing strings in different context should be avoided.

P.S. Théo is a localizer for the French team, setting checkin-needed since he doesn't have commit access to Gaia (neither have I).

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/8a057d221f6aa26254fd34c853187c7663e70330

Comment 5

[Théo Chevalier]

Attachment: [v1.3 only] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/14768

Hey David, sorry, second PR. Since we are in "soft string freeze" on 1.3 now, I reused the old string as a placeholder of the new one. Basically, it gives localizers an opportunity to shorten the button without breaking the string freeze.
We did that in other places, bug 944749 is a good example.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): -- original setringtone feature
[User impact] if declined: Truncated button / Bad l10n in title and button
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky): Very low
[String changes made]: 1 optional string. (Old string will be reused if localizers don't update the new one.)

Comment 6

[David Flanagan [:djf]]

Comment on attachment 8348832 [details] [review]
[v1.3 only] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/14768

Clever reuse of other strings. I didn't know we could do that.

Comment 7

[Preeti Raghunath(:Preeti)]

David,

Do we see a need for this to be in for 1.3? As I know 1.4 is where ringtone is being re-written. This will be an exception to the process as it is beyond cut off date for approvals.

Comment 8

[David Flanagan [:djf]]

This patch was to facilitate localization and is completely low risk. At this point, I suspect only the localization team knows whether uplifting this would help them or hinder them.  Seeing needinfo for Axel.

I don't know what went wrong on this bug, since uplift approval was requested two months ago. Maybe Theo should have requested 1.3? instead of approval?

Comment 9

[Théo Chevalier]

(In reply to David Flanagan [:djf] from comment #8)
> This patch was to facilitate localization and is completely low risk. At
> this point, I suspect only the localization team knows whether uplifting
> this would help them or hinder them.  Seeing needinfo for Axel.
> 
> I don't know what went wrong on this bug, since uplift approval was
> requested two months ago. Maybe Theo should have requested 1.3? instead of
> approval?

I must admit I'm a bit lost between all those flags, sorry if I requested the wrong one.
I thought uplift was automatic once we have approval+, and I don't have access to Gaia.

Comment 10

[Francesco Lodolo [:flod]]

(In reply to Théo Chevalier [:tchevalier] from comment #9)
> I must admit I'm a bit lost between all those flags, sorry if I requested
> the wrong one.
> I thought uplift was automatic once we have approval+, and I don't have
> access to Gaia.

You had to set blocking-b2g-1.3? on the bug.

From today you need approval-gaia-v1.3+ on single patches, even if you already had the other flag (had to fight my way trough it today, and apparently we don't have much docs to help).

I have the feeling this patch would be useful, considering how long some locales are on 1.3 right now
http://transvision.mozfr.org/string/?entity=apps/setringtone/setringtone.properties:setringtone&repo=gaia_1_3

Comment 11

[Axel Hecht [:Pike]]

I don't find bugs in LocRun1.3 mentioning ringtone, so I'd not take this bug at this point.

Comment 12

[Théo Chevalier]

(In reply to Axel Hecht [:Pike] from comment #11)
> I don't find bugs in LocRun1.3 mentioning ringtone, so I'd not take this bug
> at this point.

AFAICT, this feature is not tested by QAnalysts https://docs.google.com/spreadsheet/ccc?key=0AvRct4nrPb_ldHpIZnVneHlHVGhpWUdSN3RLa2dubEE&usp=sharing#gid=10

Comment 13

[Preeti Raghunath(:Preeti)]

Comment on attachment 8348832 [details] [review]
[v1.3 only] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/14768

Per comment 11 this is not needed in 1.3 and hence minus on the same

Comment 14

[Francesco Lodolo [:flod]]

Attachment: screenshot.png

Screenshot of it (which is the shortest one in the bucket) and pt-BR.

This is broken all over the place, and clearly not covered by QA.

Comment 15

[Francesco Lodolo [:flod]]

For the record, I completely forgot about this bug. At the time I had Théo explain to me how to reach this screen: go in Music, tap a song, tap the share icon, chose to use it as a ringtone, and here you are. 
Same string is used for both title and button.

Comment 16

[Axel Hecht [:Pike]]

I think the user impact is minor. Minor impact in a minor ux flow.

Comment 17

[David Flanagan [:djf]]

It is a UX flow that we are going to be promoting heavily in 1.4.  Custom ringtones is our most highly requested feature from users. The feature kind of snuck into 1.3, so it doesn't surprise me that it is not getting much testing.  But I think it will be used a lot, and if simple patches like this will make it better, we should land them, I think.

Also relevant: https://twitter.com/BoredBrendanJS/status/434210559563554816

Comment 18

[Axel Hecht [:Pike]]

We took the fix for 1.4. At this point in the 1.3 schedule, though, this is just not severe enough.