Closed
Bug 950491
Opened 11 years ago
Closed 11 years ago
When viewing a dependency graph, an "uninitialized value" warning is thrown
Categories
(Bugzilla :: Dependency Views, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
733 bytes,
patch
|
mail
:
review+
|
Details | Diff | Splinter Review |
In Bugzilla 4.5.1, I get:
showdependencygraph.cgi: Use of uninitialized value $lang in hash element at Bugzilla/Util.pm line 754.
This warning comes from template_var():
return $cache->{$lang}->{$name} if defined $cache->{$lang};
I suspect bug 797636 is responsible for this warning.
|
Assignee | |
Comment 1•11 years ago
|
||
Actually, this warning is thrown since bug 853638 landed. showdependencygraph.cgi is the single CGI script which calls display_value() itself, and so $template->process(), which sets $lang for us, has not been called yet.
Depends on: 853638
|
|
Assignee | |
Comment 2•11 years ago
|
||
This replicates the old code, i.e. if no language is defined, it falls back to ''. This way, there is no need to wait for $template->process() from being called.
Attachment #8347776 -
Flags: review?(bugzilla.1.wurblzap)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8347776 -
Flags: review?(simon)
|
|
||
Updated•11 years ago
|
Attachment #8347776 -
Flags: review?(simon)
Attachment #8347776 -
Flags: review?(bugzilla.1.wurblzap)
Attachment #8347776 -
Flags: review+
|
|
||
Updated•11 years ago
|
Flags: approval+
|
||
Comment 3•11 years ago
|
||
Thanks for taking this, Simon. It would have taken some more days until I could've gotten around to it.
|
|
Assignee | |
Comment 4•11 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Util.pm
Committed revision 8835.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•