950531 - --with-libxul-sdk builds broken by bug 935881

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Essentially, the build system complains that the FINAL_LIBRARY for mfbt, which is mozglue, is unknown. That's because, really, we shouldn't be building mfbt at all when building --with-libxul-sdk, as it's part of the sdk.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Don't build mfbt when building --with-libxul-sdk

Comment 2

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b545ee26212b

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b545ee26212b

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8347839 [details] [diff] [review]
Don't build mfbt when building --with-libxul-sdk

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 950531
User impact if declined: Building firefox-on-xulrunner, or any libxul-sdk-based application using our build system fails.
Testing completed (on m-c, etc.): Patch is used on debian to build iceweasel-on-xulrunner.
Risk to taking this patch (and alternatives if risky): Effectively a noop for tbpl builds.
String or IDL/UUID changes made by this patch: None

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4efc91df009d