Closed Bug 950567 Opened 6 years ago Closed 6 years ago

[Media Encoder] phase-in libmkv library

Categories

(Core :: Audio/Video: Recording, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: rlin, Assigned: rlin)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

From https://bugzilla.mozilla.org/show_bug.cgi?id=891705#c36 suggest.
The WebM muxer would re-use some function from libmkv in WebM project.
Assignee: nobody → rlin
Attached patch patch v1Splinter Review
Attachment #8347910 - Flags: review?(giles)
Comment on attachment 8347910 [details] [diff] [review]
patch v1

Review of attachment 8347910 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks. I think you'll also have to add the symbols you use to layout/media/symbols.def.in as well, so the windows build can find them in the separate gkmedias library.
Attachment #8347910 - Flags: review?(giles) → review+
Re the patch, our goal should be to get those changes upstream, so you might want to consider cleaning them and splitting them into smaller pieces, one for each build problem.
Attached patch check-in patchSplinter Review
carry reviewer, separate source /gecko patch.
Comment on attachment 8351343 [details] [diff] [review]
check-in patch

Need build system guys to review the build flag.
Attachment #8351343 - Flags: review?(gps)
Comment on attachment 8351343 [details] [diff] [review]
check-in patch

Cancel review, wait muxer patch and land together.
Attachment #8351343 - Flags: review?(gps)
Efaust brought to my attention that libmkv/update.sh doesn't actually apply the patches we're carrying, which is part of what the script is supposed to do. The version I reviewed did. What happened there?
This patch already phased in on this change set.
https://hg.mozilla.org/mozilla-central/rev/a331400db013
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Component: Video/Audio → Video/Audio: Recording
You need to log in before you can comment on or make changes to this bug.