950567 - [Media Encoder] phase-in libmkv library

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect)

Description

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

From https://bugzilla.mozilla.org/show_bug.cgi?id=891705#c36 suggest.
The WebM muxer would re-use some function from libmkv in WebM project.

Comment 1

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: patch v1

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8347910 [details] [diff] [review]
patch v1

Review of attachment 8347910 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks. I think you'll also have to add the symbols you use to layout/media/symbols.def.in as well, so the windows build can find them in the separate gkmedias library.

Comment 3

[Ralph Giles (:rillian)]

Re the patch, our goal should be to get those changes upstream, so you might want to consider cleaning them and splitting them into smaller pieces, one for each build problem.

Comment 4

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: check-in patch

carry reviewer, separate source /gecko patch.

Comment 5

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

try result.
https://tbpl.mozilla.org/?tree=Try&rev=a88f33cf035b

Comment 6

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Comment on attachment 8351343 [details] [diff] [review]
check-in patch

Need build system guys to review the build flag.

Comment 7

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Comment on attachment 8351343 [details] [diff] [review]
check-in patch

Cancel review, wait muxer patch and land together.

Comment 8

[Ralph Giles (:rillian)]

Efaust brought to my attention that libmkv/update.sh doesn't actually apply the patches we're carrying, which is part of what the script is supposed to do. The version I reviewed did. What happened there?

Comment 9

[Ralph Giles (:rillian)]

Corrected in bug 966078.

Comment 10

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Bechen use this bug https://bugzilla.mozilla.org/show_bug.cgi?id=891705
https://bug891705.bugzilla.mozilla.org/attachment.cgi?id=8365806
to phase in all of the patches that required by WebM....

Comment 11

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

This patch already phased in on this change set.
https://hg.mozilla.org/mozilla-central/rev/a331400db013