Closed Bug 950696 Opened 11 years ago Closed 11 years ago

Cache pref for whether to enable tiled thebes layers

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla29
Project Flags:
blocking-b2g 1.3+
Tracking Flags:
Tracking Status
firefox27 --- wontfix
firefox28 --- fixed
firefox29 --- fixed
b2g-v1.2 --- fixed

People

(Reporter: cwiiis, Assigned: cwiiis)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

Add gfxPlatform::GetPrefLayersEnableTiles()
8.19 KB, patch
BenWa
: review+
Details | Diff | Splinter Review 
So I accidentally added some pref gets in critical bits of code recently, which is no good. I don't really have a good defence for the act, I know better - I guess I was tired or something...

Anyway, let's fix this properly.
Blocks: 907743, 915673
Do as said. Will set review flags when I've verified it builds.
Let's make sure this possible perf regression doesn't get shipped with 1.3.
blocking-b2g: --- → 1.3?
Get it reviewed and land it.
blocking-b2g: 1.3? → 1.3+

        Attachment #8348073 -
        Attachment is obsolete: true

        Attachment #8348084 -
        Flags: review?(bgirard)

        Attachment #8348084 -
        Flags: review?(bgirard) → review+

    
    

    
  
Comment on attachment 8348084 [details] [diff] [review]
Add gfxPlatform::GetPrefLayersEnableTiles()

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Prefs read unnecessarily during time-critical code
User impact if declined: Slight performance hit
Testing completed (on m-c, etc.): Locally and now on inbound
Risk to taking this patch (and alternatives if risky): Low
String or IDL/UUID changes made by this patch: None

        Attachment #8348084 -
        Flags: approval-mozilla-aurora?

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/0f2c8d212def
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29

        Attachment #8348084 -
        Flags: approval-mozilla-aurora?

    
  
Whiteboard: [qa-]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: