950730 - Update Metro Button Text on Holly

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Marina Samuel [:emtwo]]

Attachment: v1: Update Metro button text on Holly

Should be "Relaunch in *Brand* for Windows 8 Touch" instead of "Relaunch in Windows 8 style *Brand*"

Comment 1

[Marina Samuel [:emtwo]]

Comment on attachment 8348122 [details] [diff] [review]
v1: Update Metro button text on Holly

Bug 924914 comment 56 has a request that we update this text

Comment 2

[Marina Samuel [:emtwo]]

http://hg.mozilla.org/projects/holly/rev/072edc42109d

Comment 3

[Marina Samuel [:emtwo]]

Hi Yuan,

Does the updated Metro button text need to be uplifted to Aurora? I'm not sure if they'd allow a string uplift but if it would otherwise really confuse users or if there is a legal issue with the current button text then maybe we can request it.

Comment 4

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

I thought we have shipped those string changes in the previous uplift. It's important to get the right messaging as soon as we can, so there will be no confusion branding-wise and interaction-wise. 

Thanks

Comment 5

[Marina Samuel [:emtwo]]

Comment on attachment 8348122 [details] [diff] [review]
v1: Update Metro button text on Holly

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Part of Bug 924860. Branding was decided a little later than the code had shipped.

User impact if declined: Inconsistent branding / user confusion

Testing completed (on m-c, etc.): Is currently on holly and the new text shows up as expected.

Risk to taking this patch (and alternatives if risky): minimal risk, simply a string change

String or IDL/UUID changes made by this patch: New string switchToMetroCmd2.label is added and used instead of switchToMetroCmd.label

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3baaeac88faf

Comment 7

[Francesco Lodolo [:flod]]

This bug is extremely confusing. We broke string freeze on Aurora, which I don't like but I can get, but why did this string land on Holly and not in mozilla-central too?

http://hg.mozilla.org/mozilla-central/file/325c74addeba/browser/locales/en-US/chrome/browser/browser.dtd#l435

Comment 8

[Marina Samuel [:emtwo]]

This string is not added on mozilla-central because we have different strings for the different UI 
(Australis). 

On Australis we use these strings for the metro button: http://dxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/customizableui/customizableWidgets.properties#34

The string here http://hg.mozilla.org/mozilla-central/file/325c74addeba/browser/locales/en-US/chrome/browser/browser.dtd#l435 is actually not being used anywhere.

Comment 9

[Francesco Lodolo [:flod]]

Two scenarios on next merge day:
* mozilla-central (Australis) is merged to mozilla-aurora, everything works fine.
* holly is merged to mozilla-aurora because Australis still has issues, localizers working on mozilla-central will end up with a missing string after merge day.

It's just one string so far, so no big deal, but this shouldn't become an habit: l10n is not tracking holly, just mozilla-central, so landing of string changes only on holly shouldn't be happening (IMO).

Comment 10

[Marina Samuel [:emtwo]]

This hopefully shouldn't happen again. It was only because the Metro branding decision was made after the old strings had landed. Is this one string ok for localization or should I also land it on mozilla-central? (note it wouldn't be used there)

Comment 11

[Francesco Lodolo [:flod]]

On mozilla-central there are already several unused strings (switchToMetroCmd.label is definitely one), so we'll need to clean up things anyway after Australis starts riding the train.

I don't know the actual status of Australis, but I think it's still better to land this on mozilla-central anyway, just in case something goes wrong. It also makes l10n merges between aurora and central less painful.

Comment 12

[:Gijs (out for now; he/him)]

(FWIW, I added the string to the 'remove post australis' block as part of bug 966759 because I was reviewing the other discrepancies anywhere and it was cheap. There should be no more discrepancy even if we back Australis out of aurora and use holly instead)