Closed
Bug 950731
Opened 12 years ago
Closed 11 years ago
Firefox reliably crashes (in image decoding), when running WebGL game
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
VERIFIED
FIXED
mozilla29
People
(Reporter: dave, Assigned: seth)
References
Details
(4 keywords, Whiteboard: [bugday-20140122])
Crash Data
Attachments
(1 file)
12.77 KB,
text/plain
|
Details |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131112160018
Steps to reproduce:
Run this game: http://apps.playcanvas.com/dave/goingaround/ld48
Play the game. (Click to start, then click to move through the rooms. Double click on items to interact, e.g. the fruit bowl, the toilet, the freezer)
Actual results:
Very soon into the game FF will crash.
Expected results:
The game should run without crashing the browser
![]() |
||
Comment 1•12 years ago
|
||
Severity: normal → critical
Status: UNCONFIRMED → NEW
Crash Signature: [@ RtlEnterCriticalSection | PR_Lock | imgFrame::ApplyDirtToSurfaces() ]
status-firefox28:
--- → ?
status-firefox-esr24:
--- → unaffected
tracking-firefox26:
--- → ?
tracking-firefox27:
--- → ?
tracking-firefox28:
--- → ?
tracking-firefox29:
--- → ?
Component: Untriaged → ImageLib
Ever confirmed: true
OS: Mac OS X → All
Product: Firefox → Core
![]() |
||
Comment 2•12 years ago
|
||
Regression window(m-i):
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/a9d6d86a8090
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130704 Firefox/25.0 ID:20130704094644
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/77c0bebf47ed
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130704 Firefox/25.0 ID:20130704114744
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a9d6d86a8090&tochange=77c0bebf47ed
In local build
First bad: 6bc751e34867
Last Good: a9d6d86a8090
Regressed by: Bug 888499
Blocks: 888499
Keywords: regression
![]() |
||
Updated•12 years ago
|
Keywords: crash,
reproducible
Comment 3•12 years ago
|
||
Milan - can you find someone to look at this regression? It doesn't look to me like a chemspill driver, but leaving the tracking noms up until we know more.
Assignee: nobody → milan
Flags: needinfo?(milan)
Comment 4•12 years ago
|
||
#1 Mac crash for Firefox 26. Other signatures...
RtlpWaitOnCriticalSection | RtlpDeCommitFreeBlock | PR_Lock | mozilla::image::RasterImage::FinishedSomeDecoding(mozilla::image::RasterImage::eShutdownIntent, mozilla::image::RasterImage::DecodeRequest*)
bp-9faea48e-15fd-4e2b-91eb-f25502131225
cairo_surface_detach_snapshot
bp-deb75156-1406-455d-8cbb-559962131224
Android PR_Lock | imgFrame::ApplyDirtToSurfaces() bp-fbdfa188-47ea-4bc9-a8a9-2d87f2131225
Crash Signature: [@ RtlEnterCriticalSection | PR_Lock | imgFrame::ApplyDirtToSurfaces() ] → [@ RtlEnterCriticalSection | PR_Lock | imgFrame::ApplyDirtToSurfaces() ]
[@ PR_Lock | imgFrame::ApplyDirtToSurfaces()]
[@ RtlpWaitOnCriticalSection | RtlpDeCommitFreeBlock | PR_Lock | mozilla::image::RasterImage::FinishedSomeDecoding(mozilla::image::Ra…
Comment 5•12 years ago
|
||
Based on the regression range, it's the off main thread image animation that Seth has been maintaining. CC-ing :jgilbert because of STR.
Assignee: milan → seth
Flags: needinfo?(milan)
Comment 6•12 years ago
|
||
At this point we would not chemspill FF26 for this, but tracking for later versions so we keep an eye on mac volume and hopefully find either a backout or a low risk forward fix in the next couple of weeks of FF27 (beta 4 going to build in a couple of days from now).
status-firefox26:
--- → affected
status-firefox27:
--- → affected
status-firefox29:
--- → affected
Keywords: topcrash-mac
Comment 7•11 years ago
|
||
In a debug build, the STR trigger:
{
###!!! ABORT: Asked to discard with open decoder!: '!mDecoder', file /mozilla-central/image/src/RasterImage.cpp, line 1876
}
Here's the backtrace of that abort.
Comment 8•11 years ago
|
||
Jeff, since :seth is away and this is releiably reproducible top-crash ,tracking for Firefox 27 which is going to be release in a few weeks, can you please help?
Flags: needinfo?(jmuizelaar)
Comment 9•11 years ago
|
||
(Alternately, bholley might also be able to help, since he added the abort quoted in comment 7, though that was ~3 years ago).
MXR link to the abort, for reference:
http://mxr.mozilla.org/mozilla-central/source/image/src/RasterImage.cpp?rev=5a9badd6db00#1876
Updated•11 years ago
|
Hardware: x86 → All
Summary: Firefox reliably crashes running WebGL game. → Firefox reliably crashes (in image decoding), when running WebGL game
Comment 10•11 years ago
|
||
I'm not working on imagelib anymore. We should probably get someone who is to look at this.
Comment 11•11 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #7)
> Created attachment 8356741 [details]
> backtrace of ABORT_IF_FALSE
>
> In a debug build, the STR trigger:
> {
> ###!!! ABORT: Asked to discard with open decoder!: '!mDecoder', file
> /mozilla-central/image/src/RasterImage.cpp, line 1876
> }
>
> Here's the backtrace of that abort.
This sounds like the same issue as bug 943803.
Comment 12•11 years ago
|
||
Bug 943803 should have fixed this. If not please say so.
Flags: needinfo?(jmuizelaar)
Comment 13•11 years ago
|
||
(In reply to Dave Evans from comment #0)
> User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:25.0)
> Gecko/20100101 Firefox/25.0 (Beta/Release)
> Build ID: 20131112160018
>
> Steps to reproduce:
>
> Run this game: http://apps.playcanvas.com/dave/goingaround/ld48
>
> Play the game. (Click to start, then click to move through the rooms. Double
> click on items to interact, e.g. the fruit bowl, the toilet, the freezer)
>
>
> Actual results:
>
> Very soon into the game FF will crash.
>
>
> Expected results:
>
> The game should run without crashing the browser
Hi Dave, can you confirm this is fixed for you now by trying our latest beta,aurora or nightly build ?
Reporter | ||
Comment 14•11 years ago
|
||
Just tested in Aurora and latest Beta on OS X.
No crashes, seems to be fixed. :-) Thanks!
(In reply to bhavana bajaj [:bajaj] from comment #13)
> (In reply to Dave Evans from comment #0)
> > User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:25.0)
> > Gecko/20100101 Firefox/25.0 (Beta/Release)
> > Build ID: 20131112160018
> >
> > Steps to reproduce:
> >
> > Run this game: http://apps.playcanvas.com/dave/goingaround/ld48
> >
> > Play the game. (Click to start, then click to move through the rooms. Double
> > click on items to interact, e.g. the fruit bowl, the toilet, the freezer)
> >
> >
> > Actual results:
> >
> > Very soon into the game FF will crash.
> >
> >
> > Expected results:
> >
> > The game should run without crashing the browser
>
> Hi Dave, can you confirm this is fixed for you now by trying our latest
> beta,aurora or nightly build ?
Comment 15•11 years ago
|
||
Thanks.
Updated•11 years ago
|
Target Milestone: --- → mozilla29
Comment 16•11 years ago
|
||
I check the fixed. It works for me on both firefox 27, 28 and 29.
Whiteboard: [bugday-20140122]
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•