Closed Bug 950743 Opened 6 years ago Closed 6 years ago

Navigating to Component Watching responds with a 500 on retrieving userprefs.cgi

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Production
x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: mjschranz, Assigned: glob)

Details

Attachments

(2 files)

This doesn't seem to be a widespread problem because most people I work with aren't encountering it but it doesn't seem to matter what computer/browser I use. Seems to be something tied to my account specifically....

Any help figuring this out would be highly appreciated :)
Assignee: user-accounts → nobody
Component: User Accounts → Extensions: ComponentWatching
Product: Bugzilla → bugzilla.mozilla.org
QA Contact: default-qa
Version: unspecified → Production
Found the error in Sentry and investigating further:

Can't call method "name" on an undefined value at /data/www/bugzilla.mozilla.org/extensions/ComponentWatching/Extension.pm line 358.

dkl
Attached patch 950743_1.patchSplinter Review
this is happening because matthew is watching both the entire product and individual components within it.  this fixes that by setting a default component name.  i also noticed a lack of cache hints, so i've added those too.
Assignee: nobody → glob
Attachment #8348503 - Flags: review?(dkl)
Comment on attachment 8348503 [details] [diff] [review]
950743_1.patch

Review of attachment 8348503 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8348503 - Flags: review?(dkl) → review+
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/ComponentWatching/Extension.pm
Committed revision 9192.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: Extensions: ComponentWatching → Extensions
You need to log in before you can comment on or make changes to this bug.