950743 - Navigating to Component Watching responds with a 500 on retrieving userprefs.cgi

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Matthew Schranz [:mjschranz]]

Attachment: Screenshot of page + console output

This doesn't seem to be a widespread problem because most people I work with aren't encountering it but it doesn't seem to matter what computer/browser I use. Seems to be something tied to my account specifically....

Any help figuring this out would be highly appreciated :)

Comment 1

[David Lawrence [:dkl]]

Found the error in Sentry and investigating further:

Can't call method "name" on an undefined value at /data/www/bugzilla.mozilla.org/extensions/ComponentWatching/Extension.pm line 358.

dkl

Comment 2

[:glob ✱]

Attachment: 950743_1.patch

this is happening because matthew is watching both the entire product and individual components within it.  this fixes that by setting a default component name.  i also noticed a lack of cache hints, so i've added those too.

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 8348503 [details] [diff] [review]
950743_1.patch

Review of attachment 8348503 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 4

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/ComponentWatching/Extension.pm
Committed revision 9192.