Closed Bug 950785 Opened 6 years ago Closed 6 years ago

Remove unused selectWord and selectWordContext

Categories

(Firefox for Android :: Text Selection, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 29

People

(Reporter: Margaret, Unassigned)

Details

(Whiteboard: [lang=js][mentor=margaret])

Attachments

(1 file, 1 obsolete file)

Looks like we got rid of the "Select Word" context menu item, so let's get rid of these unused functions.
In fact, it looks like there are other unused function in ClipboardHelper, like selectAll and searchWith:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#6236
Assignee: nobody → mozbugs.retornam
Attached patch bug-950785.patch (obsolete) — Splinter Review
Comment on attachment 8348905 [details] [diff] [review]
bug-950785.patch

Review of attachment 8348905 [details] [diff] [review]:
-----------------------------------------------------------------

This is looking good, but I found even more things we can remove!

(I don't know if you intended for me to review this patch, but in the future, you should be sure to set the review? or feedback? flag when you want to get review/feedback on a patch.)

::: mobile/android/chrome/content/browser.js
@@ -6243,3 @@
>    share: function() {
>      SelectionHandler.shareSelection();
>    },

I know you were just following what I posted in the description, but it looks like this share method also isn't used.

Doing a search through the other ClipboardHelper methods, it also looks like copy isn't used.

I filed bug 951374 about some more ways we can clean up ClipboardHelper, so you may be interested in that as well :)
Attachment #8348905 - Flags: feedback+
Attached patch bug-950785.patchSplinter Review
updated patch to remove share as well. I've cc'ed  myself on the other bug.
Attachment #8348905 - Attachment is obsolete: true
Attachment #8349061 - Flags: review?(margaret.leibovic)
Comment on attachment 8349061 [details] [diff] [review]
bug-950785.patch

Looks good, thanks!
Attachment #8349061 - Flags: review?(margaret.leibovic) → review+
This will conflict with wesj's patch in bug 950464, but maybe he can land this for you and resolve the conflict while he does that :)
(In reply to :Margaret Leibovic from comment #6)
> This will conflict with wesj's patch in bug 950464, but maybe he can land
> this for you and resolve the conflict while he does that :)

That will be great. Thanks.
https://hg.mozilla.org/mozilla-central/rev/b329b704e89a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Assignee: mozbugs.retornam → nobody
You need to log in before you can comment on or make changes to this bug.