950809 - Avoid dereferencing |e.accelerationIncludingGravity| when null in apps/camera/js/orientation.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Michael Vines [:m1] [:evilmachines]]

e.accelerationIncludingGravity can be null and handleMotionEvent(e) doesn't handle this.

Comment 1

[Michael Vines [:m1] [:evilmachines]]

Attachment: Add null check

Comment 2

[Michael Vines [:m1] [:evilmachines]]

(1.3+ as this is blocking a camera stability test from running)

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8348221 [details] [diff] [review]
Add null check

Review of attachment 8348221 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for this patch. I think we need to use pull request of github for this patch. If it is ready, I can help to land the code.

Comment 4

[Michael Vines [:m1] [:evilmachines]]

Attachment: Add null check - PR

Carrying forward r+

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/ff81d7e4bc6984ad64d029c90b3fea0eeb501bc1

Comment 6

[Michael Vines [:m1] [:evilmachines]]

v1.3: https://github.com/mozilla-b2g/gaia/commit/73ac7fd0a822b6419a3321caceff87cb5101807b