950826 - Super toast style not matching native platform look and feel

Status: RESOLVED FIXED

(Firefox for Android :: Theme and Visual Design, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (12/16) - Screenshot

See screenshot ('Bookmark Added') vs ('Bookmark Removed). This was tested on a a KitKat (Android 4.4.x) device, LG Nexus 4.

--
Nightly (12/16)

Comment 1

[Veeti Paananen]

I've quickly hacked together drawables and styles based on the native 4.4 AOSP files. Attaching a patch and screenshot.

Comment 2

[Veeti Paananen]

Attachment: toast-screenshot.png

Comment 3

[Veeti Paananen]

Attachment: 950826.patch

Comment 4

[Aaron Train [:aaronmt]]

Comment on attachment 8350954 [details] [diff] [review]
950826.patch

Not sure you can use that licence in toast_button.xml

Comment 5

[Veeti Paananen]

toast_button.xml is a copy from another drawable bucket and already included that license.

Comment 6

[Wesley Johnston (:wesj)]

Comment on attachment 8350954 [details] [diff] [review]
950826.patch

Review of attachment 8350954 [details] [diff] [review]:
-----------------------------------------------------------------

This is originally stolen from a project by roman that shipped a custom background here. But, I wonder if we can instead steal the android drawable? i.e. use @android:drawable/toast_frame here:

https://developer.android.com/reference/android/R.drawable.html#toast_frame

It looks like its the right image http://androidxref.com/4.4_r1/xref/frameworks/base/core/res/res/drawable-hdpi/toast_frame_holo.9.png

You mind trying? The pressed state may be wrong since Android doesn't have one. Maybe that's why he didn't do this....

Comment 7

[Veeti Paananen]

> But, I wonder if we can instead steal the android drawable? i.e. use @android:drawable/toast_frame here:

That's where the v19 toast frames are from (toast.9.png). Copied straight from AOSP.

> The pressed state may be wrong since Android doesn't have one.

Native toasts don't have any concept of interactivity: actionable toasts are not a part of the standard library at all. That is why there aren't any drawables for a pressed toast in the AOSP frameworks. Thus, I had to create the pressed state drawable myself based on the originals.

Comment 8

[Aaron Train [:aaronmt]]

review ping?

Comment 9

[Wesley Johnston (:wesj)]

Comment on attachment 8350954 [details] [diff] [review]
950826.patch

Review of attachment 8350954 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry. Yeah, I'm just trying to think of a way to use the built in drawables so that we're not constantly chasing Google's tail here. Lets do this for now and I'll file a separate bug to look into better ways to fix this.

Comment 10

[Brian Nicholson (:bnicholson)]

Ping for landing?

Comment 11

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/2fca335e35c6

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2fca335e35c6