950830 - [WebVTT] Clean up TODO comments in TextTrackCue.h

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Comment 1

[Rick Eyre (:reyre)]

Attachment: Bug 950830 - Clean up TextTrackCue style and TODO comments r=rillian

Some style fixes and removal of position validation TODO comment. That landed in bug 882743.

Comment 2

[Rick Eyre (:reyre)]

Thanks for review Ralph.

Try: https://tbpl.mozilla.org/?tree=Try&rev=47512e5f22d5

Comment 3

[Rick Eyre (:reyre)]

Looks green.

Comment 4

[Rick Eyre (:reyre)]

Attachment: Bug 950830 - Clean up TextTrackCue style and TODO comments r=rillian

Rebasing against current. Carrying forward r=rillian.

Please land bug 949642 before this.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00aa14a1f461

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/f07ae342c086 because something from the push this was in introduced a new intermittent failure on Android: https://tbpl.mozilla.org/php/getParsedLog.php?id=32309229&tree=Mozilla-Inbound

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/00aa14a1f461

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Merged backout to mozilla-central
https://hg.mozilla.org/mozilla-central/rev/f07ae342c086

Comment 9

[Rick Eyre (:reyre)]

Failure was caused by bug 921484. Try: https://tbpl.mozilla.org/?tree=Try&rev=262a49175fb5

Please land bug 949642 first.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/db72ae988131

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/db72ae988131