Run extra forgetSkippable calls per CC not per slice

RESOLVED FIXED in mozilla29

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla29
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The extra forget skippable logic should be moved out of PrepareForCycleCollectionSlice and into BeginCycleCollectionCallback. This will require passing the extra forget skippable count via gCCStats.

This will fix the case where the browser is in the middle of an ICC, then nsJSContext::CycleCollectNow gets called with positive aExtraForgetSkippableCalls, which get triggered before the ICC is finished, and thus ignored.  This will also let us turn the dynamic check in nsCycleCollector::ForgetSkippable that we're idle into an assert.

I think this isn't pressing because we don't request extra forgetSkippable calls in normal circumstances, but it should be a nice cleanup.
(Assignee)

Updated

5 years ago
Assignee: nobody → continuation
(Assignee)

Comment 1

5 years ago
Created attachment 8355024 [details] [diff] [review]
Run forgetSkippable per CC not per slice.

try run: https://tbpl.mozilla.org/?tree=Try&rev=b40db2b8506e
Attachment #8355024 - Flags: review?(bugs)

Updated

5 years ago
Attachment #8355024 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/ca04c2d514e1
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.