951024 - No haptic feedback/vibration on text selection

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[Veeti Paananen]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36

Steps to reproduce:

Select text


Actual results:

No vibration on selection start


Expected results:

A slight vibration should occur as with native text areas and fields

Comment 1

[Veeti Paananen]

Attachment: patch.diff

Comment 2

[Aaron Train [:aaronmt]]

I see Chrome does this.

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 8348507 [details] [diff] [review]
patch.diff

Review of attachment 8348507 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/TextSelection.java
@@ +128,5 @@
>                          if (mActionModeTimerTask != null)
>                              mActionModeTimerTask.cancel();
>                          showActionMode(message.getJSONArray("actions"));
> +
> +                        mVibrator.vibrate(20);

Lets just use the code we have in GeckoAppShell here:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoAppShell.java#1438

i.e. you can make this just a one line change:

GeckoAppShell.performHapticFeedback(true);

Comment 4

[Veeti Paananen]

Attachment: 160705.diff

Comment 5

[Veeti Paananen]

Attachment: 160705.diff

Oops.

Comment 6

[Wesley Johnston (:wesj)]

Sorry for the delay. Looked into this more. This will trigger even if we're just showing the single select handle. Do we want it then? I can't seem to make this happen on my phone in any apps to test, so I'd just like some detail before we land.

Comment 7

[Veeti Paananen]

Sorry, but what is a "single select handle" and where is it used?

Comment 8

[Wesley Johnston (:wesj)]

Sorry. thats just words I make up in my head :)

I was trying to describe the little arrow that shows up when you tap in a textbox that already has text in it and points to where the blinking cursor is. We show the action mode whenever that little arrow is shown as well..

Comment 9

[Wesley Johnston (:wesj)]

(In reply to Wesley Johnston (:wesj) from comment #8)
> tap in a textbox that already has text in it

err... I meant "tap in a textbox that is already focused (i.e. tap in a text box twice)"

Comment 10

[Veeti Paananen]

Oh, I see. I don't think that's desirable and it definitely doesn't match the native behavior. How's this?

Comment 11

[Veeti Paananen]

Attachment: 951024.patch

Comment 12

[Wesley Johnston (:wesj)]

Comment on attachment 8356594 [details] [diff] [review]
951024.patch

Review of attachment 8356594 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks :)

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/d8c00c658654

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d8c00c658654