Closed
Bug 951157
Opened 11 years ago
Closed 11 years ago
Clear seer DB when clearing history
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 29
People
(Reporter: mfinkle, Assigned: mfinkle)
References
Details
Attachments
(2 files)
938 bytes,
patch
|
blassey
:
review+
|
Details | Diff | Splinter Review |
1.72 KB,
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
The seer DB is not cleared when clearing the history via [Clear private data]. It's because the sanitizer for Android was not updated when the desktop version was updated in bug 881804. This patch just adds the same code to the Android version of Sanitizer.jsm
Attachment #8348746 -
Flags: review?(blassey.bugs)
Assignee | ||
Comment 1•11 years ago
|
||
A followup patch to remove desktop specific code from the Android sanitizer:
* We don't have a searchbar in XUL
* We don't use the Open Location dialog or preference
Assignee: nobody → mark.finkle
Attachment #8348757 -
Flags: review?(blassey.bugs)
Updated•11 years ago
|
Attachment #8348746 -
Flags: review?(blassey.bugs) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 8348757 [details] [diff] [review]
Remove desktop code v0.1
Wes is probably a better reviewer for this chunk
Attachment #8348757 -
Flags: review?(blassey.bugs) → review?(wjohnston)
Comment 3•11 years ago
|
||
Comment on attachment 8348757 [details] [diff] [review]
Remove desktop code v0.1
Review of attachment 8348757 [details] [diff] [review]:
-----------------------------------------------------------------
::: mobile/android/modules/Sanitizer.jsm
@@ -149,5 @@
> catch (e) { }
>
> - // Clear last URL of the Open Web Location dialog
> - try {
> - Services.prefs.clearUserPref("general.open_location.last_url");
It doesn't look like Desktop uses this anymore either :)
Attachment #8348757 -
Flags: review?(wjohnston) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/084f1f645c2d
https://hg.mozilla.org/mozilla-central/rev/26e97bf73504
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•