Clear seer DB when clearing history

RESOLVED FIXED in Firefox 29

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

Trunk
Firefox 29
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Created attachment 8348746 [details] [diff] [review]
Clear seer DB v0.1

The seer DB is not cleared when clearing the history via [Clear private data]. It's because the sanitizer for Android was not updated when the desktop version was updated in bug 881804. This patch just adds the same code to the Android version of Sanitizer.jsm
Attachment #8348746 - Flags: review?(blassey.bugs)
Created attachment 8348757 [details] [diff] [review]
Remove desktop code v0.1

A followup patch to remove desktop specific code from the Android sanitizer:
* We don't have a searchbar in XUL
* We don't use the Open Location dialog or preference
Assignee: nobody → mark.finkle
Attachment #8348757 - Flags: review?(blassey.bugs)
Attachment #8348746 - Flags: review?(blassey.bugs) → review+
Comment on attachment 8348757 [details] [diff] [review]
Remove desktop code v0.1

Wes is probably a better reviewer for this chunk
Attachment #8348757 - Flags: review?(blassey.bugs) → review?(wjohnston)
Comment on attachment 8348757 [details] [diff] [review]
Remove desktop code v0.1

Review of attachment 8348757 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/modules/Sanitizer.jsm
@@ -149,5 @@
>          catch (e) { }
>  
> -        // Clear last URL of the Open Web Location dialog
> -        try {
> -          Services.prefs.clearUserPref("general.open_location.last_url");

It doesn't look like Desktop uses this anymore either :)
Attachment #8348757 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/084f1f645c2d
https://hg.mozilla.org/mozilla-central/rev/26e97bf73504
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.