951167 - [Australis] ImTranslator add-on makes the nav-bar buttons disappear

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Paul Silaghi, QA [:pauly]]

Attachment: IMTranslator.png

https://addons.mozilla.org/en-US/firefox/addon/imtranslator/?src=cb-dl-users

Actual results: Most of the buttons from the nav-bar disappear after restart
29.0a1 (2013-12-16), Win 7 x64

Comment 1

[Peter J. Sloetjes]

IMTranslator messed up the persistence of the currentset attribute when I looked into this issue in the past in response to questions from users of my own add-ons. Perhaps IMTranslator could be 'de-featured' until it is fixed.

Comment 2

[:Gijs (he/him)]

Yeah... this is similar code to the gTranslator add-on (bug 971395). :-(
 
849       if (toolbar.localName == "toolbar" &&  toolbar.getAttribute("customizable")=="true" && toolbar.id=="nav-bar") 
850       {              
851 	        var newSet = "";
852 	        var child = toolbar.firstChild;
853 	        while(child){               
854 	          newSet += child.id+",";
855 	          child = child.nextSibling;
856 	        }
857                 newSet = newSet + "ImTranslator-translator-toolbar-button,"
858 	        toolbar.currentSet = newSet;
859 	        toolbar.setAttribute("currentset", newSet);
860 	        toolboxDocument.persist(toolbar.id, "currentset");
861 	        BrowserToolboxCustomizeDone(true);
862 	        break; 
863 	}
864      }

They shouldn't be doing this. They should read toolbar.currentSet before, or just use toolbar.insertItem (both of those will work both pre- and post-Australis) - or switch to CustomizableUI.

Moving this to tech evangelism...

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Adding the developers to the CC list. There was a very recent update that claims support for 29, but maybe this was overlooked.

Comment 4

[:Gijs (he/him)]

(In reply to Jorge Villalobos [:jorgev] from comment #3)
> Adding the developers to the CC list. There was a very recent update that
> claims support for 29, but maybe this was overlooked.

Ah. I used our MXR addons instance, don't know if the code that's there has been updated to reflect that update...

Comment 5

[ImTranslator]

(In reply to Jorge Villalobos [:jorgev] from comment #3)
> Adding the developers to the CC list. There was a very recent update that
> claims support for 29, but maybe this was overlooked.

Thanks everyone for the notes. Please accept our sincerer apologies for this situation. Our technical department was alerted to solve the issue ASAP.

Comment 6

[ImTranslator]

Thanks a lot for your attention and the comments you gave
us regarding the conflict of ImTranslator 7.6  and Firefox 29+.

Our developers are working with a new release of ImTransdlator
that should meet all you requirements.

We need some time to finish our fixes.
We appreciate your help.

Comment 7

[ImTranslator]

Thanks for your help.
This is the latest version (7.6.1) of ImTranslator.
http://imtranslator.net/downloads/imtranslator-fix29.xpi
It works without any conflicts.
Please check it out and let us know.

Comment 8

[ImTranslator]

(In reply to Jorge Villalobos [:jorgev] from comment #3)
> Adding the developers to the CC list. There was a very recent update that
> claims support for 29, but maybe this was overlooked.

Thanks for your help.
This is the latest version (7.6.1) of ImTranslator.
http://imtranslator.net/downloads/imtranslator-fix29.xpi
It works without any conflicts.
Please check it out and let us know.

Comment 9

[Peter J. Sloetjes]

When I tested ImTranslator 7.6.1 in Firefox 30.0a1, after I accepted the options dialog without a change, all toolbar buttons were still removed except the ImTranslator button :(

Please put some more work into it, because ImTranslator certainly is a useful extension (for example because it allows easy comparison of different translator services).

Comment 10

[ImTranslator]

Thanks a lot.
This is the last fix, and it works properly:
http://imtranslator.net/downloads/imtranslator-fix30.xpi

Comment 11

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to ImTranslator from comment #10)
> Thanks a lot.
> This is the last fix, and it works properly:
> http://imtranslator.net/downloads/imtranslator-fix30.xpi

This version works well for me. When are you planning on submitting this to AMO?

Comment 12

[Jorge Villalobos [:jorgev] (he/him)]

This was fixed by the developer in the latest version.