951230 - toolkit/components/places fails to link with generational GC enabled

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Jon Coppeard (:jonco)]

Attempting to build the browser with generational GC enabled gives the following error:

../../../../../dist/include/js/RootingAPI.h:646: error: undefined reference to 'JS::HeapCellRelocate(js::gc::Cell**)'
../../../../../dist/include/js/RootingAPI.h:643: error: undefined reference to 'JS::HeapCellPostBarrier(js::gc::Cell**)'
collect2: error: ld returned 1 exit status
make[6]: *** [test_IHistory] Error 1
make[5]: *** [toolkit/components/places/tests/cpp/binaries] Error 2

This is very similar to bug 942928.

I traced this down to the fix for bug 887836.  This makes URLSearchParams derive from nsWrapperCache, which adds a dependecy on the JS engine.  This has caused test_IHistory to fail to link.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug951230-ggc-browser-link-error

Patch to link this testcode against the JS engine.

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8355226 [details] [diff] [review]
bug951230-ggc-browser-link-error

Review of attachment 8355226 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/places/tests/cpp/Makefile.in
@@ +3,5 @@
> +# You can obtain one at http://mozilla.org/MPL/2.0/. */
> +
> +LIBS += \
> +	$(MOZ_JS_LIBS) \
> +	$(MOZ_ZLIB_LIBS)

You need a ifndef ZLIB_IN_MOZGLUE

Comment 3

[Jon Coppeard (:jonco)]

Attachment: bug951230-ggc-browser-link-error-v2

Thanks, patch updated.

Comment 4

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eda85da69267

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eda85da69267