951246 - Blob sent via IAC is received with no content

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Amir Nissim (:amirn)]

More information:

When sending a blob with the Inter-app Communications API,
the receiver receives a content-less blob.

Comment 1

[Gregor Wagner [:gwagner]]

Do you have a test-case as well?

Comment 2

[Amir Nissim (:amirn)]

STR:

1. checkout branch EverythingMe/rocketbar2-blob-icons
   https://github.com/EverythingMe/gaia/commits/rocketbar2-blob-icons
2. open the rocketbar
3. search for any query
4. icons are not displayed

5. checkout previous commit which uses base64 [bc6988ce7378acb44b73dddeea8f978f3e42c182]
6. repeat steps 2-3
5. icons *are* displayed

Comment 3

[Gene Lian (I already quit Mozilla)]

IAC uses normal cpmm/ppmm to pass blob through IPC. It's supposed to be working. Will check it out when I'm available. That would be great if anyone could also help with this. Thanks!

Comment 4

[Gene Lian (I already quit Mozilla)]

Hi Henry, do you have bandwidth taking a look? :)

IAC is using normal cpmm/ppmm to deliver blob. It it fails, then it means our activities fails either, which is not supposed to be happening.

Comment 5

[Gene Lian (I already quit Mozilla)]

Hi Amir, sorry for not getting back to this. Is this still an issue?

Hi Sean, I'm thinking this might be a good bug for you.

Comment 6

[Amir Nissim (:amirn)]

E.me no longer uses IAC (see bug 958923) so the STR in comment 2 is no longer relevant.

AFAIK the bug was not fixed.

Comment 7

[Sean Lin [:seanlin] (inactive from Mar 2016)]

After verification, the issue doesn't appear reproducible. (I've also tested against the Gaia code base in comment 2 along with the latest Gecko.) And there has been quite a few changes for both blob and IAC implementation since the issue was filed. Perhaps the issue got fixed (no matter intentionally or not) by some of them.

In addition, I just added couple test cases to ensure IAC works well with blob for now as well as the future.

Comment 8

[Sean Lin [:seanlin] (inactive from Mar 2016)]

Attachment: Add tests to ensure IAC works well with blobs

Comment 9

[Gene Lian (I already quit Mozilla)]

Comment on attachment 8423573 [details]
Add tests to ensure IAC works well with blobs

Overall looks good to me bug just some minor polishes.

Comment 10

[Gene Lian (I already quit Mozilla)]

Btw, whenever you make a commit (or PR?) you can see your test result running on the Travis (i.e. a kind of Try server on the Gaia side) which is shown at the bottom of the GitHub page. Your test is green. ;)

All is well — The Travis CI build passed · Details

Comment 11

[Gene Lian (I already quit Mozilla)]

Comment on attachment 8423573 [details]
Add tests to ensure IAC works well with blobs

Nice! You can ask for checkin-needed after Travis passes. Thank you!

Comment 12

[Carsten Book [:Tomcat]]

master : https://github.com/mozilla-b2g/gaia/commit/f06cdc75a8495ff3f1e0c437b68561540bc93cd3