Closed Bug 951250 Opened 11 years ago Closed 10 years ago

Keybord shortcut conflict: tabView.commandkey vs responsiveDesignTool.commandkey

Categories

(Mozilla Localizations :: ga-IE / Irish, defect)

Product:
Mozilla Localizations
Component:
ga-IE / Irish
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: andrei, Assigned: kscanne)

References

Details

There is a conflict between opening the Tab View and opening the Responsive Design Tool From bug 951244: With Ctrl+Shift+E we expect to open the tabView: <!ENTITY tabView.commandkey "e"> We end up with opening the Responsive Design Tool: <!ENTITY responsiveDesignTool.commandkey "E"> This does not affect OSX, since the ResponsiveDesignTool gets opened by Alt+Cmd+E
Hi Kevin, any progress here? We're still seeing this fail on mozmill with ga-IE builds: http://mozmill-release.blargon7.com/#/functional/report/94e33fe3d7ec0be6dbbfa0a702bf1b3e
Flags: needinfo?(kscanne)
Kevin, would there be any chance to get this fixed for Firefox 28?
Can your tool suggest a better key? I don't have a lot of time to look into this right now.
Flags: needinfo?(kscanne)
"M" is the default key for this action. on ga-IE: Ctrl+Shift+M enters Private Browsing Mode (which is Ctrl+Shift+P on en-US) I think changing this to "M" would be a no-no since that is a much more used feature. (since we'd have to move Private Browsing Mode to another key). So why not use "P" for the tabView? From what I tested there's no action for Ctrl[Cmd]+Shift+P right now on ga-IE.
Command keys should as best follow the settings for en-US. Unless you have the keys not available on your keyboard for the locale. So what should probably be done, is to check the settings for en-US and apply them to ga-IE, and not randomly looking for another possible key. This will also not be helpful.
Kevin, have you read my last comment on this bug? As I have stated it is not useful to change the command key given the feedback from Andrei in comment 4. The change which you have pushed now, makes your locale the only one which doesn't follow the general command key. :/ http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=tabView.commandkey http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=responsiveDesignTool.commandkey You should really have changed the command key for the responsiveDesignTool to 'M' and left 'e' for tabView.
Thanks Kevin! Andrei, can you please check a todays Aurora build of ga-IE if all is working fine? Thanks.
Flags: needinfo?(andrei.eftimie)
Works excellent for the issues we had in bug 951244
Flags: needinfo?(andrei.eftimie)
Kevin, any chance to get this in Beta as well?
Flags: needinfo?(kscanne)
(In reply to Andrei Eftimie from comment #11) > Kevin, any chance to get this in Beta as well? http://hg.mozilla.org/releases/l10n/mozilla-beta/ga-IE/rev/10e4c6a1ced0 But I think he didn't request a new sign-off yet.
Committed and signed off, awaiting review.
Flags: needinfo?(kscanne)
I think this issue can be closed. The fix was landed in 29, so all current versions have it.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.