Closed Bug 951256 Opened 7 years ago Closed 7 years ago

Disambiguate rendertrace output for different APZC instances

Categories

(Core :: Panning and Zooming, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(2 files)

We added rendertrace output to APZC in bug 927954 but if we have multiple APZC instances in play at a time their outputs are all mixed together. We should log the guid to be able to sort them out.
Convenience function
Attachment #8348944 - Flags: review?(chrislord.net)
Comment on attachment 8348944 [details] [diff] [review]
Part 1 - Add a GetGuid()

Review of attachment 8348944 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. I assume that the extra few bytes this uses, temporarily, is ok.

::: gfx/layers/ipc/AsyncPanZoomController.cpp
@@ +1719,3 @@
>  }
>  
>  void AsyncPanZoomController::GetGuid(ScrollableLayerGuid* aGuidOut)

Kind of wonder why we even have this version of the function now...?
Attachment #8348944 - Flags: review?(chrislord.net) → review+
Comment on attachment 8348945 [details] [diff] [review]
Part 2 - Log the guid with rendertrace output

Review of attachment 8348945 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8348945 - Flags: review?(chrislord.net) → review+
(In reply to Chris Lord [:cwiiis] from comment #3)
> Kind of wonder why we even have this version of the function now...?

Yeah I'll probably remove it eventually. It'll propagate changes all the way back to metro code so I didn't want to do it here.

remote:   https://hg.mozilla.org/integration/b2g-inbound/rev/4673519522ef
remote:   https://hg.mozilla.org/integration/b2g-inbound/rev/e7f5aff00418
You need to log in before you can comment on or make changes to this bug.