951256 - Disambiguate rendertrace output for different APZC instances

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

We added rendertrace output to APZC in bug 927954 but if we have multiple APZC instances in play at a time their outputs are all mixed together. We should log the guid to be able to sort them out.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 1 - Add a GetGuid()

Convenience function

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 2 - Log the guid with rendertrace output

Comment 3

[Chris Lord [:cwiiis]]

Comment on attachment 8348944 [details] [diff] [review]
Part 1 - Add a GetGuid()

Review of attachment 8348944 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. I assume that the extra few bytes this uses, temporarily, is ok.

::: gfx/layers/ipc/AsyncPanZoomController.cpp
@@ +1719,3 @@
>  }
>  
>  void AsyncPanZoomController::GetGuid(ScrollableLayerGuid* aGuidOut)

Kind of wonder why we even have this version of the function now...?

Comment 4

[Chris Lord [:cwiiis]]

Comment on attachment 8348945 [details] [diff] [review]
Part 2 - Log the guid with rendertrace output

Review of attachment 8348945 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

(In reply to Chris Lord [:cwiiis] from comment #3)
> Kind of wonder why we even have this version of the function now...?

Yeah I'll probably remove it eventually. It'll propagate changes all the way back to metro code so I didn't want to do it here.

remote:   https://hg.mozilla.org/integration/b2g-inbound/rev/4673519522ef
remote:   https://hg.mozilla.org/integration/b2g-inbound/rev/e7f5aff00418

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4673519522ef
https://hg.mozilla.org/mozilla-central/rev/e7f5aff00418