951291 - msys terminal window (cmd) can't be closed with |exit| after MozillaBuild ran and ssh-agent.exe is still alive

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Windows 8.1 Pro 64 bit, MozillaBuild 1.9.0pre

After launching the start-shell-l10n.bat or start-shell-msvc2010.bat (haven't tested others) and terminating it with |exit|, the shell window can't be closed by typing exit again if ssh-agent.exe is active.

Steps to reproduce:
1. Launch start-shell-msvc2010.bat
2. Type in your ssh password.
3. End the MozillaBuild shell with |exit|.
4. Try to close the msys window by typing |exit|.

Actual result:
Window remains, don't get a new input prompt. Can close the window by clicking on the close button.

Expected result:
Window closes.

I used a MozillaBuild 1.9.0pre environment some weeks ago on a Win XP 32 bit system, and can't remember issues with closing the window.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Related to bug 418655 it sounds like.

Comment 2

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Attachment: Kill ssh-agent on exit

This irritates me as it means I need to manually kill ssh-agent if I want the command prompt to close, so I've made the attached patch which will clean up on exit.

There's a problem with multiple instances, though. The first instance, which launched ssh-agent, will also kill it, regardless of any subsequently opened instances. I don't think this patch is ready until that is addressed, though it will work for my purposes.

I'm not sure whether this would apply to bug 418655, as I'm not clear how the window is being closed in that case.

Comment 3

[Gregory Szorc [:gps]]

`trap` is pretty unreliable since anything else in the shell can set a trap and undo yours. But as a default, it may be acceptable. Alternatively, we could write something that launches ssh-agent and a sub-shell and cleans up ssh-agent when the sub-shell exits. That's a bit of complexity though. Not sure if we want an extra process sticking around just to manage ssh-agent.

Comment 5

[Mitchell Hentges [:mhentges] 🦀]

This is fixed by the MSYS2 migration.