mach mochitest-plain overwrites WebRTC logging environment variables

RESOLVED FIXED in mozilla29

Status

Firefox Build System
General
RESOLVED FIXED
5 years ago
3 months ago

People

(Reporter: drno, Assigned: drno)

Tracking

Trunk
mozilla29

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 8348939 [details] [diff] [review]
Patch for only setting WebRTC logging variables if they don't exist yet

When running ./mach mochitest-plain with any given test the existing environment variables are overwritten with values specified in /build/automation.py.in and/or /build/automationutils.py. This makes proper debugging of WebRTC tests locally on a developer machine harder.

The attached patch only overwrites the WebRTC related environment variables in case they are not present already.
(Assignee)

Updated

5 years ago
OS: Mac OS X → All
Hardware: x86 → All
Note that the stuff in automation.py isn't used for Mochitests anymore. (We're mid-refactor to get rid of automation.py, it's a bit confusing right now.)
Depends on: 841566
(Assignee)

Comment 2

5 years ago
Indeed, I only patched both occurrences, because I did not understand what or where automation.py is getting used.
(Assignee)

Updated

5 years ago
Attachment #8348939 - Flags: review?(ted)
Attachment #8348939 - Flags: review?(ted) → review+
Assignee: nobody → drno
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Attachment #8348939 - Attachment is obsolete: true
(Assignee)

Comment 3

5 years ago
Created attachment 8349739 [details] [diff] [review]
Patch for only setting WebRTC logging variables if they don't exist yet
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Nils, bugs are resolved automatically when merged to m-c. Please don't resolve them when they land on inbound.
Flags: needinfo?(drno)
Target Milestone: --- → mozilla29
(Assignee)

Comment 10

5 years ago
Thanks for the clarification. Did not know that. So Fixed gets set automatically when merged to m-c?
Should I manually set it back, if so to what?
Flags: needinfo?(drno) → needinfo?(ryanvm)
It's fine now. It was merged to m-c in comment 8. We have scripts that do all the bug marking for us automatically when merging. It was just an FYI for next time :)
Flags: needinfo?(ryanvm)

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.