Created attachment 8348939 [details] [diff] [review] Patch for only setting WebRTC logging variables if they don't exist yet When running ./mach mochitest-plain with any given test the existing environment variables are overwritten with values specified in /build/automation.py.in and/or /build/automationutils.py. This makes proper debugging of WebRTC tests locally on a developer machine harder. The attached patch only overwrites the WebRTC related environment variables in case they are not present already.
Note that the stuff in automation.py isn't used for Mochitests anymore. (We're mid-refactor to get rid of automation.py, it's a bit confusing right now.)
Depends on: 841566
Indeed, I only patched both occurrences, because I did not understand what or where automation.py is getting used.
Attachment #8348939 - Flags: review?(ted) → review+
Attachment #8348939 - Attachment is obsolete: true
Created attachment 8349739 [details] [diff] [review] Patch for only setting WebRTC logging variables if they don't exist yet
Sorry, silly mistake on my part. Relanded. https://hg.mozilla.org/integration/mozilla-inbound/rev/06ebd514613b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Nils, bugs are resolved automatically when merged to m-c. Please don't resolve them when they land on inbound.
Thanks for the clarification. Did not know that. So Fixed gets set automatically when merged to m-c? Should I manually set it back, if so to what?
Flags: needinfo?(drno) → needinfo?(ryanvm)
It's fine now. It was merged to m-c in comment 8. We have scripts that do all the bug marking for us automatically when merging. It was just an FYI for next time :)
You need to log in before you can comment on or make changes to this bug.