951314 - mach mochitest-plain overwrites WebRTC logging environment variables

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nils Ohlmeier [:drno]]

Attachment: Patch for only setting WebRTC logging variables if they don't exist yet

When running ./mach mochitest-plain with any given test the existing environment variables are overwritten with values specified in /build/automation.py.in and/or /build/automationutils.py. This makes proper debugging of WebRTC tests locally on a developer machine harder.

The attached patch only overwrites the WebRTC related environment variables in case they are not present already.

Comment 1

[(not currently active) Ted Mielczarek]

Note that the stuff in automation.py isn't used for Mochitests anymore. (We're mid-refactor to get rid of automation.py, it's a bit confusing right now.)

Comment 2

[Nils Ohlmeier [:drno]]

Indeed, I only patched both occurrences, because I did not understand what or where automation.py is getting used.

Comment 3

[Nils Ohlmeier [:drno]]

Attachment: Patch for only setting WebRTC logging variables if they don't exist yet

Comment 4

[Nils Ohlmeier [:drno]]

https://tbpl.mozilla.org/?tree=Try&rev=afd053b11d92

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/08009e8417e9

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Backed out for Windows bustage.
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d0de9cfddcb

https://tbpl.mozilla.org/php/getParsedLog.php?id=32223370&tree=Mozilla-Inbound

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Sorry, silly mistake on my part. Relanded.
https://hg.mozilla.org/integration/mozilla-inbound/rev/06ebd514613b

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/06ebd514613b

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Nils, bugs are resolved automatically when merged to m-c. Please don't resolve them when they land on inbound.

Comment 10

[Nils Ohlmeier [:drno]]

Thanks for the clarification. Did not know that. So Fixed gets set automatically when merged to m-c?
Should I manually set it back, if so to what?

Comment 11

[Ryan VanderMeulen [:RyanVM]]

It's fine now. It was merged to m-c in comment 8. We have scripts that do all the bug marking for us automatically when merging. It was just an FYI for next time :)