951341 - [Flatfish][Gallery] thumbnails are created much larger than needed on Flatfish

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[David Flanagan [:djf]]

The following lines in gallery/js/MetdataParser.js cause really big thumbnails to be created for photos on Flatfish:

  // If we generate our own thumbnails, aim for this size.
  // Calculate needed size from longer side of the screen.
  var THUMBNAIL_WIDTH = Math.round(
                          Math.max(window.innerWidth, window.innerHeight) *
                            window.devicePixelRatio / 4);

This code assumes that the biggest thumbanils will be needed when the device is in portrait mode and that there will be 4 columns of thumbnails in that mode.  That assumption is no longer valid for the tablet form factor.

I'm not sure what the Flatfish resolution is, but I suspect that we're creating thumbnails two or three times too big, and that this is causing time and memory performance issues.

Comment 1

[David Flanagan [:djf]]

Needinfo George since he was the person working on this new form factor.

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Yes you're right.
On tablet, we have 4 pics in one row in portrait, which means each pictures must larger or equal 800/4 and also 6 pics in one row in pickView and landscape, so the max of width/height will be divided by 6 when device is not phone.

Please kindly check.
Thanks.

Comment 3

[David Flanagan [:djf]]

Comment on attachment 8349168 [details]
PR to master

Looks good, but I think we can do even better and be more correct. Please see my suggestion on github. If that suggestion looks good to you, you can land it without requesting another review.

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks David,
https://github.com/mozilla-b2g/gaia/commit/bb68c0794c99250094319c4202c52f40d2d3bb3b