Closed
Bug 951445
Opened 12 years ago
Closed 12 years ago
flake8 mozillians
Categories
(Participation Infrastructure :: Phonebook, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
2013-12-19
People
(Reporter: sancus, Assigned: sancus)
Details
(Whiteboard: [kb=1218959] [qa-])
Lets run flake8 over mozillians, fix everything, and then add flake8 to our regular jenkins checks.
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [kb=1218959]
|
||
Comment 1•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/mozillians
https://github.com/mozilla/mozillians/commit/2befca11c370a56e7145f113ba6da28970d03fa9
[Bug 951445] Fix PEP8 styling issues
https://github.com/mozilla/mozillians/commit/ee5e8d095b969eb348b2c29754fe7962974f108a
[Fix Bug 951445] Run flake8 on Jenkins
https://github.com/mozilla/mozillians/commit/230d1c6ef8328afdee47588e73b3a69b5750073e
Merge pull request #752 from Sancus/flake8
[Bug 951445] Fix PEP8 issues and run flake8
|
|
||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → sancus
|
|
Assignee | |
Comment 2•12 years ago
|
||
PEP8 changes are qa- because they're code quality and have no effect on site functionality.
Jenkins is also now running a check for pep8 compliance, which can be verified by checking any PR build, like this one: https://ci.mozilla.org/job/mozillians_github/1049/console
You can see the "Check PEP8" text and failures at the end of the console log.
Status: RESOLVED → VERIFIED
Whiteboard: [kb=1218959] → [kb=1218959] [qa-]
|
||
Updated•12 years ago
|
Target Milestone: --- → 2013-12-19
You need to log in
before you can comment on or make changes to this bug.
Description
•