951469 - TryChooser is showing "N/A" for all queues

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Visit http://trychooser.pub.build.mozilla.org/
 2. Look at the Build Queue / Test Queue entries

ACTUAL RESULTS: They're all N/A
EXPECTED RESULTS: Most should not be N/A

Comment 1

[Daniel Holbert [:dholbert]]

The Browser Console reports a syntax error at tryload.js:91, which I think is pointing to the redundant comma at the end of the final line here:
>        totalTestLoad["macosx64"] = Math.max(
>                                     Math.max(
>                                      load_try_test["mac10.6-rev4"] + load_nontry_test["mac10.6-rev4"],
>                                    , load_try_test["mac10.8"] + load_nontry_test["mac10.8"]);

It's possible that fixing that will fix this.

Comment 2

[Aki Sasaki (not active)]

Looks like fallout from http://hg.mozilla.org/build/tools/rev/e94ddbd4e309

Comment 3

[Aki Sasaki (not active)]

Attachment: fix_trychooser

Comment 4

[Daniel Holbert [:dholbert]]

Comment on attachment 8349127 [details] [diff] [review]
fix_trychooser

This is just dropping the redundant (nested) max() and the redundant comma, yes?

Seems reasonable to me.

Comment 5

[Aki Sasaki (not active)]

Comment on attachment 8349127 [details] [diff] [review]
fix_trychooser

https://hg.mozilla.org/build/tools/rev/1d410ae59a56

Comment 6

[Daniel Holbert [:dholbert]]

(aki: Do you know yet whether that tweak actually fixes the N/A-everywhere issue?)

Comment 7

[Aki Sasaki (not active)]

Not yet, no, but it looks like http://hg.mozilla.org/build/tools/rev/e94ddbd4e309 introduced badness, so it's a guess.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Yeah, it does. You can checkout http://hg.mozilla.org/build/tools and open trychooser/index.html in Firefox to hack/test this stuff.

Comment 9

[Aki Sasaki (not active)]

Heh.  Should trychooser redirect to http://hg.mozilla.org/build/tools/raw-file/default/trychooser/index.html ?