Closed Bug 951518 Opened 11 years ago Closed 11 years ago

Fix whitespace on Connect page

Categories

(DevTools :: Framework, defect)

Product:
DevTools
Component:
Framework
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox26 unaffected, firefox27 fixed, firefox28 fixed, firefox29 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 29
Tracking Flags:
Tracking Status
firefox26 --- unaffected
firefox27 --- fixed
firefox28 --- fixed
firefox29 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Added missing ending whitespace to help text
1.44 KB, patch
jryans
: review+
lsblakk
: approval-mozilla-aurora+
lsblakk
: approval-mozilla-beta+
Details | Diff | Splinter Review
A follow up patch to correct some whitespace in the Connect page's help string in bug 927974 was missed and not landed. Since it's a few versions, I'm moving it to a separate bug.
As noted in bug 927974 comment 22, the was given r+ by flod. He also noted that the string ID could remain the same.
Attachment #8349179 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/c7493af8325d
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
I assume we can uplift this to Aurora and Beta, since the string ID didn't have to change?
status-firefox26: --- → unaffected
status-firefox27: --- → affected
status-firefox28: --- → affected
status-firefox29: --- → fixed
Comment on attachment 8349179 [details] [diff] [review] Added missing ending whitespace to help text [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 927974 User impact if declined: Missing whitespace on Web Developer -> Connect page Testing completed (on m-c, etc.): m-c Risk to taking this patch (and alternatives if risky): None String or IDL/UUID changes made by this patch: A string is changed to add a space. L10n did not think a string ID change was needed in m-c.
Attachment #8349179 - Flags: approval-mozilla-aurora?
Comment on attachment 8349179 [details] [diff] [review] Added missing ending whitespace to help text [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 927974 User impact if declined: Missing whitespace on Web Developer -> Connect page Testing completed (on m-c, etc.): m-c Risk to taking this patch (and alternatives if risky): None String or IDL/UUID changes made by this patch: A string is changed to add a space. L10n did not think a string ID change was needed in m-c.
Attachment #8349179 - Flags: approval-mozilla-beta?
Comment on attachment 8349179 [details] [diff] [review] Added missing ending whitespace to help text If no ID change, we can go ahead.
Attachment #8349179 - Flags: approval-mozilla-beta?
Attachment #8349179 - Flags: approval-mozilla-beta+
Attachment #8349179 - Flags: approval-mozilla-aurora?
Attachment #8349179 - Flags: approval-mozilla-aurora+
Whiteboard: [qa-]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: