Closed Bug 951538 Opened 8 years ago Closed 7 years ago

[Settings] Move "Reset" option up one level

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Other
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(tracking-b2g:backlog)

RESOLVED FIXED
2.0 S6 (18july)
tracking-b2g backlog

People

(Reporter: nhsieh, Assigned: gasolin)

References

Details

(Whiteboard: [priority][p=1])

Attachments

(3 files)

Now the system reset option exist in very deep level. 
Settings-->Device information-->More Information-->Reset Phone

It will makes users hard to find that and the relationship with More Information is weak. 
So I suggest move this option to first level and put in "Device" catagory.
Attached image settings_device.jpg
And also change the option name from "Reset" to "Factory reset" . Please check the attachment for detail.
Flags: needinfo?(jcheng)
Bruce, let's add this to backlog
blocking-b2g: --- → 1.4?
Flags: needinfo?(jcheng) → needinfo?(bhuang)
Moving this to system platform backlog, we should consider this as part of the overall settings rearrangement.
Blocks: 908549
Flags: needinfo?(bhuang)
We'll address all settings reordering in 1.5.
blocking-b2g: 1.4? → ---
ni Omega for overall settings consideration
blocking-b2g: --- → backlog
Flags: needinfo?(ofeng)
Whiteboard: [priority]
After overall consideration, I moved the "Reset Phone" one level up.
See bug 1001312 for the latest UX spec.
Flags: needinfo?(ofeng)
Summary: [Settings] Move "Reset" option up two levels → [Settings] Move "Reset" option up one level
Assignee: nobody → gasolin
Attachment #8450876 - Flags: review?(arthur.chen)
Attached image about_reset.png
follow omega's design, put reset button in device information panel
Whiteboard: [priority] → [priority][p=1]
Target Milestone: --- → 2.0 S6 (18july)
Comment on attachment 8450876 [details] [review]
pull request redirect to github

Looks good to me, thanks.
Attachment #8450876 - Flags: review?(arthur.chen) → review+
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/6c2a1b999251900aed67dff4ec44f9c4cd3165a8

thanks!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Sorry to reopen but you need to back this out or fix it.

You just added a string called "reset", when we already have one. This breaks tools (they can't detect the new string) and localization (you can't localize them differently).

Existing
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/locales/settings.en-US.properties#L11

New
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/locales/settings.en-US.properties#L1070

My suggestion would be to call the new string reset-header
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Note: a while ago I filed bug 1013831 to make tests fail when a patch introduces duplicated strings. Until that is fixed, reviewers need to check for those in patches with strings.
Thanks for finding it. reverted cc889a33ef28ce8a3528363f7fae67d946d40b0b
change string to `reset-head`.  

merged to https://github.com/mozilla-b2g/gaia/commit/1e9aac6be5df06efb636a169698f1d3464244e69

thanks!


@Francesco we saw strings are composed in different format like `xxx = ooo` and `xxx2=ooo2`.
Does it effect l10n team's work if we try to unify them in single format?
If it's fine, which format is preferred?
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Flags: needinfo?(francesco.lodolo)
Resolution: --- → FIXED
A renamed string is basically a new string for tools, so it's a really bad idea to start a sprint and rename all of them: they will be reported as new, and people will have to localize them again.

Also: if you have a "reset2", it's only because at some point there was a string called "reset" and it was changed. If you go back to "reset", the risk is to consider as valid some very old localizations that were never updated.

About naming conventions, I'd really prefer a more semantic approach: for example reset-label, reset-button, reset-header, etc. That will make things easier when is English is unclear: is "reset" a name, a verb (action)?
Flags: needinfo?(francesco.lodolo)
that make sense to me. Thanks for clarification.
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.