951538 - [Settings] Move "Reset" option up one level

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Neo Hsieh [:neo]]

Now the system reset option exist in very deep level. 
Settings-->Device information-->More Information-->Reset Phone

It will makes users hard to find that and the relationship with More Information is weak. 
So I suggest move this option to first level and put in "Device" catagory.

Comment 1

[Neo Hsieh [:neo]]

Attachment: settings_device.jpg

And also change the option name from "Reset" to "Factory reset" . Please check the attachment for detail.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

Bruce, let's add this to backlog

Comment 3

[Bruce Huang [:bhuang] (inactive)]

Moving this to system platform backlog, we should consider this as part of the overall settings rearrangement.

Comment 4

[Bruce Huang [:bhuang] (inactive)]

We'll address all settings reordering in 1.5.

Comment 5

[Bruce Huang [:bhuang] (inactive)]

ni Omega for overall settings consideration

Comment 6

[Omega Feng [:Omega] [:馮於懋]]

After overall consideration, I moved the "Reset Phone" one level up.
See bug 1001312 for the latest UX spec.

Comment 7

[[e-mail]]

Attachment: pull request redirect to github

Comment 8

[[e-mail]]

Attachment: about_reset.png

follow omega's design, put reset button in device information panel

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8450876 [details] [review]
pull request redirect to github

Looks good to me, thanks.

Comment 10

[[e-mail]]

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/6c2a1b999251900aed67dff4ec44f9c4cd3165a8

thanks!

Comment 11

[Francesco Lodolo [:flod]]

Sorry to reopen but you need to back this out or fix it.

You just added a string called "reset", when we already have one. This breaks tools (they can't detect the new string) and localization (you can't localize them differently).

Existing
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/locales/settings.en-US.properties#L11

New
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/locales/settings.en-US.properties#L1070

My suggestion would be to call the new string reset-header

Comment 12

[Francesco Lodolo [:flod]]

Note: a while ago I filed bug 1013831 to make tests fail when a patch introduces duplicated strings. Until that is fixed, reviewers need to check for those in patches with strings.

Comment 13

[[e-mail]]

Thanks for finding it. reverted cc889a33ef28ce8a3528363f7fae67d946d40b0b

Comment 14

[[e-mail]]

change string to `reset-head`.  

merged to https://github.com/mozilla-b2g/gaia/commit/1e9aac6be5df06efb636a169698f1d3464244e69

thanks!


@Francesco we saw strings are composed in different format like `xxx = ooo` and `xxx2=ooo2`.
Does it effect l10n team's work if we try to unify them in single format?
If it's fine, which format is preferred?

Comment 15

[Francesco Lodolo [:flod]]

A renamed string is basically a new string for tools, so it's a really bad idea to start a sprint and rename all of them: they will be reported as new, and people will have to localize them again.

Also: if you have a "reset2", it's only because at some point there was a string called "reset" and it was changed. If you go back to "reset", the risk is to consider as valid some very old localizations that were never updated.

About naming conventions, I'd really prefer a more semantic approach: for example reset-label, reset-button, reset-header, etc. That will make things easier when is English is unclear: is "reset" a name, a verb (action)?

Comment 16

[[e-mail]]

that make sense to me. Thanks for clarification.