951567 - B2G get_about_memory.py script will show "Invalid memory report(s): non-sentence other description" in Firefox

Status: RESOLVED WORKSFORME

(Toolkit :: about:memory, defect)

Description

[Askeing Yen[:askeing][:fyen]]

Attachment: 2013-12-18 17:19:00.png

### ENV
Buri
Gaia      5123f0dc6f4712c60b4714579b7cc6a9644c8542
Gecko     http://hg.mozilla.org/mozilla-central/rev/d58545aaeab9
BuildID   20131217084757
Version   29.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013

### STR
1. cd tools
2. ./get_about_memory.py

### Expected
After pull memory reports, then open memory report in Firefox.

### Actual
After pull memory reports, open Firefox with "Invalid memory report(s): non-sentence other description" error message.

Comment 1

[Askeing Yen[:askeing][:fyen]]

### ENV
Buri
Gaia      545aacf3feff6430140cc9ade757002df4895b77
Gecko     http://hg.mozilla.org/mozilla-central/rev/b1e5ade62913
BuildID   20131217040201
Version   29.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013

Works fine.

Comment 2

[Jason Smith [:jsmith]]

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b1e5ade62913&tochange=d58545aaeab9

Comment 3

[Nicholas Nethercote [inactive]]

> After pull memory reports, open Firefox with "Invalid memory report(s):
> non-sentence other description" error message.

Try updating m-c.  I removed that check in https://hg.mozilla.org/mozilla-central/rev/c9e9f2940aef, which landed on m-c about a day ago.

Comment 4

[Askeing Yen[:askeing][:fyen]]

It still can reproduce on my Unagi and Buri with pvt m-c builds.

Buri
Gaia      9a8757985e663978f9ea5c85e47ff6ccef096ec9
Gecko     http://hg.mozilla.org/mozilla-central/rev/530209bff5e8
BuildID   20131222040201
Version   29.0a1

Unagi
Gaia      e2f0e09e980b1cb3275a0bb033931cb48f9d521c
Gecko     http://hg.mozilla.org/mozilla-central/rev/862cb6a1cc88
BuildID   20131218040201
Version   29.0a1

Comment 5

[Nicholas Nethercote [inactive]]

Your builds must still be out-of-date in some way.  The code that performed that check no longer exists in mozilla-central;  it was removed in part 1 (see line 1.66 of https://hg.mozilla.org/mozilla-central/rev/c9e9f2940aef) of bug 945973, which landed on mozilla-central on December 17.

Comment 6

[Askeing Yen[:askeing][:fyen]]

I run the get_about_memory.py script with PVT mozilla-central builds, not local builds.
And the get_about_memory.py script comes from latest B2G project.
  ~/workspace/mozilla-B2G/tools$ git log -n1 --oneline 
  605ee4d Merge pull request #307 from thomastsai/test-setup.sh
  ~/workspace/mozilla-B2G/tools$ ls
  fix_b2g_stack.py  get_about_memory.py  get_gc_cc_log.py  include  mach_b2g_bootstrap.py  update-tools

Comment 7

[Paul Yang [:pyang] (away)]

Hi Nicholas,
I got error message pretty similar:
"Invalid memory report(s): non-sentence other description: mem/processes/process(\init, pid=1)/other-files/init/[r-xp], /init [r-xp]"

Device is buri, version as below
Gaia      9a8757985e663978f9ea5c85e47ff6ccef096ec9
Gecko     http://hg.mozilla.org/mozilla-central/rev/530209bff5e8
BuildID   20131222040201
Version   29.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013

b2g project commit is:

commit 605ee4d4f6a9d654fe58979b827bea219c165f23
Merge: 35a93a9 f9bb197
Author: Marco Chen <[e-mail]>
Date:   Sun Dec 22 22:00:12 2013 -0800

    Merge pull request #307 from thomastsai/test-setup.sh
    
    supporting fugu dsds build with VGA mode by MOZ_B2G_DSDS=2 ./build.sh


Attached please find memory reports as well

Comment 8

[Paul Yang [:pyang] (away)]

Attachment: memory-reports

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

What needs to be up to date here is not your b2g checkout, but the version of Firefox you are loading the memory reports in.  The report from comment 8 loads fine in the 12/21 Nightly.

Comment 10

[Askeing Yen[:askeing][:fyen]]

:njn and :Khuey,
Thanks for your help :)

Comment 11

[Paul Yang [:pyang] (away)]

Clear blocking flag since using obsolete version.