951605 - Regression: EV green lock and non-EV gray lock swapped

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Henri Sivonen (:hsivonen) (away from Bugzilla until 2025-12-29)]

Steps to reproduce:
 1) Navigate to https://hsivonen.fi/ (or any non-EV https URL) in Fennec.
 2) Navigate to https://www.mozilla.org/en-US/ (or any EV https URL) in Fennec.

Actual results:
A green lock icon is shown in the location bar for the non-EV page and a gray lock for the EV page.

Expected results:
Expected the lock to be gray for non-EV and green for EV.

Comment 1

[Aaron Train [:aaronmt]]

Last good revision: 1ad9af3a2ab8 (2013-12-12)
First bad revision: 8b5875dc7e31 (2013-12-13)

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1ad9af3a2ab8&tochange=8b5875dc7e31

Last good revision: f5bb944954a5
First bad revision: 800878f01d5d
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f5bb944954a5&tochange=800878f01d5d

Likely bug 943915.

Comment 2

[Aaron Train [:aaronmt]]

Actually probably bug 945212.

Comment 3

[:Margaret Leibovic]

Attachment: patch

This problem is caused by the fact that we're using mode.ordinal() here to set the image level:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/toolbar/BrowserToolbar.java#987

But the order of items in the SecurityMode enum doesn't match the image levels in site_security_level.xml (even though there's a comment above it that says it does!).

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/f95fea48b259

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f95fea48b259