Closed Bug 951605 Opened 7 years ago Closed 7 years ago

Regression: EV green lock and non-EV gray lock swapped

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set
major

Tracking

()

VERIFIED FIXED
Firefox 29
Tracking Status
firefox26 --- unaffected
firefox27 --- unaffected
firefox28 --- unaffected
firefox29 --- verified
fennec 29+ ---

People

(Reporter: hsivonen, Assigned: Margaret)

References

()

Details

(Keywords: regression, reproducible)

Attachments

(1 file)

Steps to reproduce:
 1) Navigate to https://hsivonen.fi/ (or any non-EV https URL) in Fennec.
 2) Navigate to https://www.mozilla.org/en-US/ (or any EV https URL) in Fennec.

Actual results:
A green lock icon is shown in the location bar for the non-EV page and a gray lock for the EV page.

Expected results:
Expected the lock to be gray for non-EV and green for EV.
Summary: EV green lock and non-EV gray lock swapped → Regression: EV green lock and non-EV gray lock swapped
Last good revision: 1ad9af3a2ab8 (2013-12-12)
First bad revision: 8b5875dc7e31 (2013-12-13)

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1ad9af3a2ab8&tochange=8b5875dc7e31

Last good revision: f5bb944954a5
First bad revision: 800878f01d5d
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f5bb944954a5&tochange=800878f01d5d

Likely bug 943915.
Actually probably bug 945212.
Blocks: 945212
No longer blocks: 943915
Assignee: nobody → margaret.leibovic
tracking-fennec: ? → 29+
Attached patch patchSplinter Review
This problem is caused by the fact that we're using mode.ordinal() here to set the image level:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/toolbar/BrowserToolbar.java#987

But the order of items in the SecurityMode enum doesn't match the image levels in site_security_level.xml (even though there's a comment above it that says it does!).
Attachment #8349582 - Flags: review?(mark.finkle)
Attachment #8349582 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/f95fea48b259
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.