Closed Bug 951686 Opened 6 years ago Closed 6 years ago

[Skia] Problem with handling of opaque SkBitmaps

Categories

(Core :: Graphics, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: kevin, Assigned: kevin)

Details

Attachments

(1 file, 1 obsolete file)

Some of the SkBitmaps created in the Skia backend (like the one created in GetBitmapForSurface) do not correctly handle format FORMAT_B8G8R8X8. Also, it *appears* that ConvertBGRXToBGRA may not be necessary since the setIsOpaque(true) should in theory do what we want. It may also be worth explore updating Skia and using setAlphaType(kIgnore_SkAlphaType) if setIsOpaque(true) doesn't work as expected.

After making some quick changes to call setIsOpaque(true) in all of the appropriate places (and removing the calls to ConvertBGRXToBGRA), several hundred failing reftests now pass. It also seems to cause a set of new failures which will be investigated.

Patch in progress.
Well, that's embarrassing. Reports of my success have been greatly exaggerated. It was a typo in my greprefs that provided the good results, not my fix. Anyway, still seems to be an issue here, so I'll dig in.
Attachment #8350690 - Flags: review?(gwright)
The attached patch does seem to fix a couple of hundred reftests on linux, so maybe I was right after all.
Attachment #8350690 - Flags: review?(gwright) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3b57aef6724b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.