951686 - [Skia] Problem with handling of opaque SkBitmaps

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Kevin Simons [:kevsim] (Telenor)]

Some of the SkBitmaps created in the Skia backend (like the one created in GetBitmapForSurface) do not correctly handle format FORMAT_B8G8R8X8. Also, it *appears* that ConvertBGRXToBGRA may not be necessary since the setIsOpaque(true) should in theory do what we want. It may also be worth explore updating Skia and using setAlphaType(kIgnore_SkAlphaType) if setIsOpaque(true) doesn't work as expected.

After making some quick changes to call setIsOpaque(true) in all of the appropriate places (and removing the calls to ConvertBGRXToBGRA), several hundred failing reftests now pass. It also seems to cause a set of new failures which will be investigated.

Patch in progress.

Comment 1

[Kevin Simons [:kevsim] (Telenor)]

Well, that's embarrassing. Reports of my success have been greatly exaggerated. It was a typo in my greprefs that provided the good results, not my fix. Anyway, still seems to be an issue here, so I'll dig in.

Comment 2

[Kevin Simons [:kevsim] (Telenor)]

Attachment: Set the SkBitmapDevice to opaque for BGRX surfaces

Comment 3

[Kevin Simons [:kevsim] (Telenor)]

The attached patch does seem to fix a couple of hundred reftests on linux, so maybe I was right after all.

Comment 4

[Kevin Simons [:kevsim] (Telenor)]

Attachment: Set the SkBitmapDevice to opaque for BGRX surfaces. r=gwright

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b57aef6724b

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3b57aef6724b