Closed Bug 951726 Opened 6 years ago Closed 6 years ago

DevTools Themes: Make top tab bar thinner

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 29

People

(Reporter: bgrins, Assigned: bgrins)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa-])

Attachments

(2 files)

There is some discussion in Bug 915414 about taking up less vertical space.  Shrinking the top tab bar is one of the things mentioned.
Attached image tab-sizes.png
Darrin,
Here is a picture with screenshots I took of various sizes.  Any thoughts?
Attachment #8349484 - Flags: ui-review?(dhenein)
Like the current one best :)
Comment on attachment 8349484 [details]
tab-sizes.png

26 looks best from a quick glance, we may want to play with the icon sizes a bit when we implement this (even shrinking by 1px on top and bottom may help with the balance/weight).
Attachment #8349484 - Flags: ui-review?(dhenein) → ui-review+
(In reply to Darrin Henein [:darrin] from comment #4)
> Comment on attachment 8349484 [details]
> tab-sizes.png
> 
> 26 looks best from a quick glance, we may want to play with the icon sizes a
> bit when we implement this (even shrinking by 1px on top and bottom may help
> with the balance/weight).

I've
Depends on: 941673
(In reply to Brian Grinstead [:bgrins] from comment #5)
> (In reply to Darrin Henein [:darrin] from comment #4)
> > Comment on attachment 8349484 [details]
> > tab-sizes.png
> > 
> > 26 looks best from a quick glance, we may want to play with the icon sizes a
> > bit when we implement this (even shrinking by 1px on top and bottom may help
> > with the balance/weight).

I've moved the icons into a single place in Bug 941673, so replacing them will be easy if you send over updated icons.  Would you like to do this before shrinking the top bar, or should I go ahead and land this and update icons later?
Flags: needinfo?(dhenein)
Lets land this now, and I will follow up with my team to get opinions on replacing them. They may be OK as is.
Flags: needinfo?(dhenein)
Just changes the min-height to 26px for the tabs.
Attachment #8356162 - Flags: review?(nfitzgerald)
Attachment #8356162 - Flags: review?(nfitzgerald) → review+
The thinner top bar looks so awkward, the top bar is actually thinner than the toolbar, and that makes no sense. Id rather wait until the toolbar is restyled first than do this now. 
I think the best would be respecting stephens design.
(In reply to Tim Nguyen [:ntim] from comment #10)
> The thinner top bar looks so awkward, the top bar is actually thinner than
> the toolbar, and that makes no sense. Id rather wait until the toolbar is
> restyled first than do this now. 
> I think the best would be respecting stephens design.

I don't see why having the tool tabs smaller than the individual tools' toolbar is a problem.

The fact of the matter is that devtools are most often used with a horizontal split, so every vertical pixel we take up gives us less room to display our UI in *and* makes that much more of the web content invisible.
https://hg.mozilla.org/mozilla-central/rev/be49376c1bd5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
Depends on: 957291
(In reply to Nick Fitzgerald [:fitzgen] from comment #11)
> (In reply to Tim Nguyen [:ntim] from comment #10)
> > The thinner top bar looks so awkward, the top bar is actually thinner than
> > the toolbar, and that makes no sense. Id rather wait until the toolbar is
> > restyled first than do this now. 
> > I think the best would be respecting stephens design.
> 
> I don't see why having the tool tabs smaller than the individual tools'
> toolbar is a problem.
> 
> The fact of the matter is that devtools are most often used with a
> horizontal split, so every vertical pixel we take up gives us less room to
> display our UI in *and* makes that much more of the web content invisible.

Well, I think the 28 or 30 options are best if you want to take less vertical space. But right now, it feels cluttered like Chrome dev tools, and I don't like it a lot.
Btw, this bug causes a regression : bug 957291
No longer depends on: 957291
Whiteboard: [qa-]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.