951726 - DevTools Themes: Make top tab bar thinner

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Brian Grinstead [:bgrins]]

There is some discussion in Bug 915414 about taking up less vertical space.  Shrinking the top tab bar is one of the things mentioned.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: tab-sizes.png

Darrin,
Here is a picture with screenshots I took of various sizes.  Any thoughts?

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

+1 for 26

Comment 3

[Tim Nguyen :ntim]

Like the current one best :)

Comment 4

[Darrin Henein [:darrin]]

Comment on attachment 8349484 [details]
tab-sizes.png

26 looks best from a quick glance, we may want to play with the icon sizes a bit when we implement this (even shrinking by 1px on top and bottom may help with the balance/weight).

Comment 5

[Brian Grinstead [:bgrins]]

(In reply to Darrin Henein [:darrin] from comment #4)
> Comment on attachment 8349484 [details]
> tab-sizes.png
> 
> 26 looks best from a quick glance, we may want to play with the icon sizes a
> bit when we implement this (even shrinking by 1px on top and bottom may help
> with the balance/weight).

I've

Comment 6

[Brian Grinstead [:bgrins]]

(In reply to Brian Grinstead [:bgrins] from comment #5)
> (In reply to Darrin Henein [:darrin] from comment #4)
> > Comment on attachment 8349484 [details]
> > tab-sizes.png
> > 
> > 26 looks best from a quick glance, we may want to play with the icon sizes a
> > bit when we implement this (even shrinking by 1px on top and bottom may help
> > with the balance/weight).

I've moved the icons into a single place in Bug 941673, so replacing them will be easy if you send over updated icons.  Would you like to do this before shrinking the top bar, or should I go ahead and land this and update icons later?

Comment 7

[Darrin Henein [:darrin]]

Lets land this now, and I will follow up with my team to get opinions on replacing them. They may be OK as is.

Comment 8

[Brian Grinstead [:bgrins]]

Attachment: theme-thinner-tabbar.patch

Just changes the min-height to 26px for the tabs.

Comment 9

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/integration/fx-team/rev/be49376c1bd5
https://tbpl.mozilla.org/?tree=Fx-Team&rev=be49376c1bd5

Comment 10

[Tim Nguyen :ntim]

The thinner top bar looks so awkward, the top bar is actually thinner than the toolbar, and that makes no sense. Id rather wait until the toolbar is restyled first than do this now. 
I think the best would be respecting stephens design.

Comment 11

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Tim Nguyen [:ntim] from comment #10)
> The thinner top bar looks so awkward, the top bar is actually thinner than
> the toolbar, and that makes no sense. Id rather wait until the toolbar is
> restyled first than do this now. 
> I think the best would be respecting stephens design.

I don't see why having the tool tabs smaller than the individual tools' toolbar is a problem.

The fact of the matter is that devtools are most often used with a horizontal split, so every vertical pixel we take up gives us less room to display our UI in *and* makes that much more of the web content invisible.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/be49376c1bd5

Comment 13

[Tim Nguyen :ntim]

(In reply to Nick Fitzgerald [:fitzgen] from comment #11)
> (In reply to Tim Nguyen [:ntim] from comment #10)
> > The thinner top bar looks so awkward, the top bar is actually thinner than
> > the toolbar, and that makes no sense. Id rather wait until the toolbar is
> > restyled first than do this now. 
> > I think the best would be respecting stephens design.
> 
> I don't see why having the tool tabs smaller than the individual tools'
> toolbar is a problem.
> 
> The fact of the matter is that devtools are most often used with a
> horizontal split, so every vertical pixel we take up gives us less room to
> display our UI in *and* makes that much more of the web content invisible.

Well, I think the 28 or 30 options are best if you want to take less vertical space. But right now, it feels cluttered like Chrome dev tools, and I don't like it a lot.
Btw, this bug causes a regression : bug 957291