951838 - We need a OS.Constants.Path.libsqlite3

Status: RESOLVED FIXED

(Toolkit :: Async Tooling, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

Attachment: OS.Constants.Path.libSqlite3

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: OS.Constants.Path.libsqlite3, v2

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8350042 [details] [diff] [review]
OS.Constants.Path.libsqlite3, v2

Review of attachment 8350042 [details] [diff] [review]:
-----------------------------------------------------------------

I'm afraid of what you're going to use this for, but ok.

::: dom/system/OSFileConstants.cpp
@@ +815,3 @@
>  #if defined(XP_MACOSX)
>      // Under MacOS X, for some reason, libxul is called simply "XUL"
> +    nsAutoString libxul(NS_LITERAL_STRING("XUL"));

Fix all this indentation now that you removed the scoping.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Well, we use this to give access to Sqlite in Workers through js-ctypes.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yeah, that's scary :)

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Attachment: OS.Constants.Path.libsqlite3, v3

Try: https://tbpl.mozilla.org/?tree=Try&rev=47c7beecab12

Comment 6

[David Teller [:Yoric] - still alive but not very active]

Attachment: OS.Constants.Path.libsqlite3, v4

Same patch, minus typo.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/f7b38a8b987d

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f7b38a8b987d