PeerConnection Mochitest in dom/media should check IceConnectionState

RESOLVED FIXED in mozilla29

Status

()

Core
WebRTC
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: drno, Assigned: drno)

Tracking

(Blocks: 1 bug)

Trunk
mozilla29
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
The test_peerConnection* tests in dom/media/test/mochitest currently do not verify that ICE was able to connect successfully as part of the tests. As an ICE connection is prerequisite for a MediaStream the IceConnectionState should be checked as part of these tests.
(Assignee)

Updated

4 years ago
Assignee: nobody → drno
(Assignee)

Updated

4 years ago
Blocks: 948249
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

4 years ago
Created attachment 8350367 [details] [diff] [review]
adding_ice_connection_checks_for_peerconnection_test.patch
(Assignee)

Updated

4 years ago
Attachment #8350367 - Flags: review?(adam)
(Assignee)

Comment 2

4 years ago
https://tbpl.mozilla.org/?tree=Try&rev=36a90431a203

Comment 3

4 years ago
Interdiff link (it's hard to get this out of the system since the old patch was on another bug): https://bugzilla.mozilla.org/attachment.cgi?oldid=8349053&action=interdiff&newid=8350367&headers=1

Comment 4

4 years ago
Comment on attachment 8350367 [details] [diff] [review]
adding_ice_connection_checks_for_peerconnection_test.patch

Review of attachment 8350367 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Once tiny nit in the comments, but otherwise is ready to go.

::: dom/media/tests/mochitest/pc.js
@@ +975,5 @@
>     */
>    var self = this;
>    // This enables tests to validate that the next ice state is the one they expect to happen
>    this.next_ice_state = ""; // in most cases, the next state will be "checking", but in some tests "closed"
> +  // This allows register their own callbacks for ICE connection state changes

s/allows register/allows tests to register/
Attachment #8350367 - Flags: review?(adam) → review+

Comment 5

4 years ago
Comment on attachment 8350367 [details] [diff] [review]
adding_ice_connection_checks_for_peerconnection_test.patch

Review of attachment 8350367 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, missed this tiny spelling issue the first time.

::: dom/media/tests/mochitest/pc.js
@@ +975,5 @@
>     */
>    var self = this;
>    // This enables tests to validate that the next ice state is the one they expect to happen
>    this.next_ice_state = ""; // in most cases, the next state will be "checking", but in some tests "closed"
> +  // This allows register their own callbacks for ICE connection state changes

s/allows register/allows tests to register/

@@ +1371,5 @@
> +   *
> +   * @param {function} onSuccess
> +   *        Callback if ICE connection status is "connected".
> +   * @param {function} onFailure
> +   *        Callback if ICE connection reaches a different state then

s/then/than/
(Assignee)

Updated

4 years ago
Attachment #8350367 - Attachment is obsolete: true
(Assignee)

Comment 6

4 years ago
Created attachment 8350777 [details] [diff] [review]
adding_ice_connection_checks_for_peerconnection_test.patch

Fixed the spelling errors Adam pointed out.
(Assignee)

Updated

4 years ago
Keywords: checkin-needed

Updated

4 years ago
Attachment #8350777 - Flags: review+
Attachment #8350777 - Flags: checkin?(adam)

Comment 7

4 years ago
Comment on attachment 8350777 [details] [diff] [review]
adding_ice_connection_checks_for_peerconnection_test.patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc7cd53d9dd1
Attachment #8350777 - Flags: checkin?(adam) → checkin+
https://hg.mozilla.org/mozilla-central/rev/fc7cd53d9dd1
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.