Closed Bug 951999 Opened 8 years ago Closed 8 years ago

[B2G][DSDS] Need to add SIM id into the WAP Push message.

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kchang, Assigned: bevis)

References

Details

Attachments

(2 files)

For DSDS, Gaia needs to know which SIM the WAP push message comes from. We need to add SIM card information into the system message which convey WAP push.
Blocks: 947198
Assignee: nobody → btseng
Hi Gene,

This patch is to expose the serviceId in the RadioInterfaceLayer to the decoded wap-push message for the further usage of WapPush App.
(Verified in both unagi/fugu. The serviceId(zero-based) was exposed correctly to wappush.js in gaia/apps/wappush.)

Thanks for your time for reviewing it.
Attachment #8351170 - Flags: review?(gene.lian)
Attachment #8351170 - Flags: review?(gene.lian) → review+
Update try server result as followed:
https://tbpl.mozilla.org/?tree=Try&rev=202569b1540d
Keywords: checkin-needed
Service ID should be used to get imsi from corresponding SIM[1], or I can fix it in bug 928775 after this bug landed.


[1] http://mxr.mozilla.org/mozilla-central/source/dom/wappush/src/gonk/WapPushManager.js#114
[checkin-needed removed]

Hi Chuck,

Thanks for reminding of getting the correct imsi in WapPushManager in DSDS projects.
Since the patch was not landed yet,
I'll fix it together with this bug. :)

Regards,
Bevis Tseng

(In reply to Chuck Lee [:chucklee] from comment #3)
> Service ID should be used to get imsi from corresponding SIM[1], or I can
> fix it in bug 928775 after this bug landed.
> 
> 
> [1]
> http://mxr.mozilla.org/mozilla-central/source/dom/wappush/src/gonk/
> WapPushManager.js#114
Keywords: checkin-needed
This patch is to fix the problem mentioned in comment#3 to get the imsi for WAP CP Message with selected service ID.
Attachment #8355120 - Flags: review?(gene.lian)
Gah, didn't realize you removed checkin-needed. Let me know if it needs to be backed out.
[leave open] for now
Whiteboard: [leave open]
Actually, that probably isn't related. Oh well, sorry for the churn.
Attachment #8355120 - Flags: review?(gene.lian) → review+
You need to log in before you can comment on or make changes to this bug.