951999 - [B2G][DSDS] Need to add SIM id into the WAP Push message.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Ken Chang[:kenkai]]

For DSDS, Gaia needs to know which SIM the WAP push message comes from. We need to add SIM card information into the system message which convey WAP push.

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch_Part_1_v1: Include serviceId into the system message of "wappush-received". r=gene

Hi Gene,

This patch is to expose the serviceId in the RadioInterfaceLayer to the decoded wap-push message for the further usage of WapPush App.
(Verified in both unagi/fugu. The serviceId(zero-based) was exposed correctly to wappush.js in gaia/apps/wappush.)

Thanks for your time for reviewing it.

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Update try server result as followed:
https://tbpl.mozilla.org/?tree=Try&rev=202569b1540d

Comment 3

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Service ID should be used to get imsi from corresponding SIM[1], or I can fix it in bug 928775 after this bug landed.


[1] http://mxr.mozilla.org/mozilla-central/source/dom/wappush/src/gonk/WapPushManager.js#114

Comment 4

[Bevis Tseng[:bevis][:btseng](Exited)]

[checkin-needed removed]

Hi Chuck,

Thanks for reminding of getting the correct imsi in WapPushManager in DSDS projects.
Since the patch was not landed yet,
I'll fix it together with this bug. :)

Regards,
Bevis Tseng

(In reply to Chuck Lee [:chucklee] from comment #3)
> Service ID should be used to get imsi from corresponding SIM[1], or I can
> fix it in bug 928775 after this bug landed.
> 
> 
> [1]
> http://mxr.mozilla.org/mozilla-central/source/dom/wappush/src/gonk/
> WapPushManager.js#114

Comment 5

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch_Part_2_v1: Get IMSI with selected service Id for Push Message of WAP CP. r=gene

This patch is to fix the problem mentioned in comment#3 to get the imsi for WAP CP Message with selected service ID.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/integration/b2g-inbound/rev/30521d0cc862

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Gah, didn't realize you removed checkin-needed. Let me know if it needs to be backed out.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

[leave open] for now

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Backed out for real-looking Gaia integration test failures.
https://hg.mozilla.org/integration/b2g-inbound/rev/ff5542c15922

https://tbpl.mozilla.org/php/getParsedLog.php?id=32517700&tree=B2g-Inbound

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Actually, that probably isn't related. Oh well, sorry for the churn.

Comment 11

[Bevis Tseng[:bevis][:btseng](Exited)]

Try server result is green:
https://tbpl.mozilla.org/?tree=Try&rev=61e9d58899bc

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/d4ba6886b24e
https://hg.mozilla.org/integration/b2g-inbound/rev/d734db94a905

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d4ba6886b24e
https://hg.mozilla.org/mozilla-central/rev/d734db94a905