[B2G][DSDS] Need to add SIM id into the WAP Push message.

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kchang, Assigned: bevis)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
For DSDS, Gaia needs to know which SIM the WAP push message comes from. We need to add SIM card information into the system message which convey WAP push.
(Reporter)

Updated

5 years ago
Blocks: 947198
(Assignee)

Updated

5 years ago
Assignee: nobody → btseng
(Assignee)

Comment 1

5 years ago
Created attachment 8351170 [details] [diff] [review]
Patch_Part_1_v1: Include serviceId into the system message of "wappush-received". r=gene

Hi Gene,

This patch is to expose the serviceId in the RadioInterfaceLayer to the decoded wap-push message for the further usage of WapPush App.
(Verified in both unagi/fugu. The serviceId(zero-based) was exposed correctly to wappush.js in gaia/apps/wappush.)

Thanks for your time for reviewing it.
Attachment #8351170 - Flags: review?(gene.lian)
Attachment #8351170 - Flags: review?(gene.lian) → review+
(Assignee)

Comment 2

5 years ago
Update try server result as followed:
https://tbpl.mozilla.org/?tree=Try&rev=202569b1540d
Keywords: checkin-needed
Service ID should be used to get imsi from corresponding SIM[1], or I can fix it in bug 928775 after this bug landed.


[1] http://mxr.mozilla.org/mozilla-central/source/dom/wappush/src/﷒0
(Assignee)

Comment 4

5 years ago
[checkin-needed removed]

Hi Chuck,

Thanks for reminding of getting the correct imsi in WapPushManager in DSDS projects.
Since the patch was not landed yet,
I'll fix it together with this bug. :)

Regards,
Bevis Tseng

(In reply to Chuck Lee [:chucklee] from comment #3)
> Service ID should be used to get imsi from corresponding SIM[1], or I can
> fix it in bug 928775 after this bug landed.
> 
> 
> [1]
> http://mxr.mozilla.org/mozilla-central/source/dom/wappush/src/gonk/
> WapPushManager.js#114
Keywords: checkin-needed
(Assignee)

Comment 5

5 years ago
Created attachment 8355120 [details] [diff] [review]
Patch_Part_2_v1: Get IMSI with selected service Id for Push Message of WAP CP. r=gene

This patch is to fix the problem mentioned in comment#3 to get the imsi for WAP CP Message with selected service ID.
Attachment #8355120 - Flags: review?(gene.lian)
Gah, didn't realize you removed checkin-needed. Let me know if it needs to be backed out.
[leave open] for now
Whiteboard: [leave open]
Actually, that probably isn't related. Oh well, sorry for the churn.
Attachment #8355120 - Flags: review?(gene.lian) → review+
Try server result is green:
https://tbpl.mozilla.org/?tree=Try&rev=61e9d58899bc
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d4ba6886b24e
https://hg.mozilla.org/mozilla-central/rev/d734db94a905
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.