952020 - Remove the MediaEncoder::OnEncoderThread()

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect)

Description

[John Lin [:jhlin][:jolin]]

|MediaEncoder| uses a static/global variable |sEncoderThread| to hold owning thread but assigns it only once in |GetEncodedData()|. When the 2nd instance is created and in use, the value will be out of date and |OnEncoderThread()| will always return false.

Comment 1

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

oh....Should not use static because there may more than two encoder instances....

Comment 2

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

This design is incorrect and cause threading problem, we should remove it.

Comment 3

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: patch v1

Comment 4

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: patch v1.1

Comment 5

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Comment on attachment 8349959 [details] [diff] [review]
patch v1.1

Hi Ralph, 
I need to remove this due to the implementation is wrong and useless.

Comment 6

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: check-in patch

carry reviewer, check-in needed
green try result
https://tbpl.mozilla.org/?tree=Try&rev=225e6494ab22

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/f7c9c09c7c41

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f7c9c09c7c41