Closed Bug 952139 Opened 6 years ago Closed 5 years ago

Enable MessagePort/MessageChannel by default

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed
relnote-firefox --- -

People

(Reporter: baku, Assigned: baku)

References

Details

(Keywords: dev-doc-complete, feature)

Attachments

(2 files, 2 obsolete files)

No description provided.
Keywords: feature, relnote
OS: Linux → All
Hardware: x86_64 → All
Attached patch enabled.patch (obsolete) — Splinter Review
We cannot land this patch until MessagePort in Workers is landed
Attachment #8514968 - Flags: review?(bugs)
Assignee: nobody → amarchesini
I wonder if we should have one extra cycle MessageChannel enabled in non-release, but disabled in beta/release. 
At least this shouldn't land any time close to the next merge.


So, (assuming bug 911972 gets fixed before the next merge) could we land this patch right 
_after_ the next merge, but land a patch which enables MessagePort/Channel for non-release branches by default before the merge.
Comment on attachment 8514968 [details] [diff] [review]
enabled.patch

I think we should not yet remove the pref, but we should just
set the pref enabled by default in all.js.
Easier and safer to just set the pref false if we see regressions in aurora or beta.

And as long as we have the pref, tests should explicitly set it.
Attachment #8514968 - Flags: review?(bugs) → review-
Attached patch enabled.patch (obsolete) — Splinter Review
Attachment #8514968 - Attachment is obsolete: true
Attachment #8515896 - Flags: review?(bugs)
Comment on attachment 8515896 [details] [diff] [review]
enabled.patch

(new patch coming)
Attachment #8515896 - Flags: review?(bugs)
Attached patch enabled.patchSplinter Review
Attachment #8515896 - Attachment is obsolete: true
Attachment #8515914 - Flags: review?(bugs)
Attachment #8515914 - Flags: review?(bugs) → review+
:baku, any reason that this hasn't landed yet?
Comment 1 does not explain why, so: why is this still turned off by default, instead of turned on so that at least in regular JS context we can make use of MessageChannel (with the webworker implementation landing in some future update, if ever, if the progress on this is any indication)? 

We patched this in 2012, it's now 2015, we're dragging our feet to a ridiculous degree given that the code to support this functionality has already landed. Let's at least get us to "partial support" instead of "not available despite the code already being in place".
Attachment #8622547 - Flags: review?(bugs) → review+
This also had test_interfaces.html failures remaining after the follow-up from comment 12 landed. Please verify that this is green across the board on Try before attempting to push again.
https://treeherder.mozilla.org/logviewer.html#?job_id=10787165&repo=mozilla-inbound
https://hg.mozilla.org/mozilla-central/rev/27b0d2176ef1
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Depends on: 1177727
For reference, I edited https://developer.mozilla.org/en-US/docs/Web/API/MessageChannel to indicate that this is available on Firefox 41 and Firefox Mobile 41 (not sure about version number for Firefox OS).
Thanks Wladimir, I've added the info in the subpages compat table and I have update Firefox 41 for developers:
https://developer.mozilla.org/en-US/Firefox/Releases/41#InterfacesAPIsDOM
Release Note Request (optional, but appreciated)
[Why is this notable]: easier/better cross-thread communication for webdevs
[Suggested wording]: Implemented HTML5 MessagePort & MessageChannel APIs
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/Channel_Messaging_API & https://developer.mozilla.org/en-US/docs/Web/API/MessageChannel
relnote-firefox: --- → ?
Removed relnote tracking on this bug as the MessagePort and MessageChannel API has already been relnoted in bug 911972. Please let me know if these two bugs are not the same.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.