952139 - Enable MessagePort/MessageChannel by default

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: enabled.patch

We cannot land this patch until MessagePort in Workers is landed

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

I wonder if we should have one extra cycle MessageChannel enabled in non-release, but disabled in beta/release. 
At least this shouldn't land any time close to the next merge.


So, (assuming bug 911972 gets fixed before the next merge) could we land this patch right 
_after_ the next merge, but land a patch which enables MessagePort/Channel for non-release branches by default before the merge.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8514968 [details] [diff] [review]
enabled.patch

I think we should not yet remove the pref, but we should just
set the pref enabled by default in all.js.
Easier and safer to just set the pref false if we see regressions in aurora or beta.

And as long as we have the pref, tests should explicitly set it.

Comment 4

[Andrea Marchesini [:baku]]

Attachment: enabled.patch

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8515896 [details] [diff] [review]
enabled.patch

(new patch coming)

Comment 6

[Andrea Marchesini [:baku]]

Attachment: enabled.patch

Comment 7

[Martin Thomson [:mt:]]

:baku, any reason that this hasn't landed yet?

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

See comment 1

Comment 9

[Pomax]

Comment 1 does not explain why, so: why is this still turned off by default, instead of turned on so that at least in regular JS context we can make use of MessageChannel (with the webworker implementation landing in some future update, if ever, if the progress on this is any indication)? 

We patched this in 2012, it's now 2015, we're dragging our feet to a ridiculous degree given that the code to support this functionality has already landed. Let's at least get us to "partial support" instead of "not available despite the code already being in place".

Comment 10

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd11384b3241

Comment 11

[Andrea Marchesini [:baku]]

Attachment: MessageChannel exposed interface to workers

Comment 12

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/465dfc26cccb

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Backed out because bug 911972 was backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/79e11098d70a

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Also, test failures after this bug landed:
https://treeherder.mozilla.org/logviewer.html#?job_id=10784754&repo=mozilla-inbound

Comment 15

[Ryan VanderMeulen [:RyanVM]]

And https://treeherder.mozilla.org/logviewer.html#?job_id=10786236&repo=mozilla-inbound

Comment 16

[Ryan VanderMeulen [:RyanVM]]

This also had test_interfaces.html failures remaining after the follow-up from comment 12 landed. Please verify that this is green across the board on Try before attempting to push again.
https://treeherder.mozilla.org/logviewer.html#?job_id=10787165&repo=mozilla-inbound

Comment 17

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/27b0d2176ef1

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/27b0d2176ef1

Comment 19

[Wladimir Palant]

For reference, I edited https://developer.mozilla.org/en-US/docs/Web/API/MessageChannel to indicate that this is available on Firefox 41 and Firefox Mobile 41 (not sure about version number for Firefox OS).

Comment 20

[Jean-Yves Perrier [:teoli]]

Thanks Wladimir, I've added the info in the subpages compat table and I have update Firefox 41 for developers:
https://developer.mozilla.org/en-US/Firefox/Releases/41#InterfacesAPIsDOM

Comment 21

[Florian Bender]

Release Note Request (optional, but appreciated)
[Why is this notable]: easier/better cross-thread communication for webdevs
[Suggested wording]: Implemented HTML5 MessagePort & MessageChannel APIs
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/Channel_Messaging_API & https://developer.mozilla.org/en-US/docs/Web/API/MessageChannel

Comment 22

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Added to FF41 release notes in Nucleus.

Comment 23

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Removed relnote tracking on this bug as the MessagePort and MessageChannel API has already been relnoted in bug 911972. Please let me know if these two bugs are not the same.