952224 - [Session Restore] Remove calls to |_ensureInitialized()| and no longer throw a "Session Store is not initialized." error

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Steven MacLeod [:smacleod]]

Bug 918024 Removed the synchronous start up fallback for sessions store. We left the calls to |_ensureInitialized()| so we would throw an error if someone attempted to trigger the removed code path.

Since Bug 918024 landed, we haven't seen reports of these errors and we should eventually remove this code if everything stays quiet.

Comment 1

[Tyler Colgan]

Attachment: Remove calls to _ensureInitialized() (version 1)

If I'm interpreting this correctly, it sounds like we want to remove _ensureInitialized() and any calls to it. I went ahead and did that in this patch; let me know if I'm on the right track.

Assuming that this is the right approach, it looks like doRestore() would no longer have a possibility of throwing an error, so I removed its |@throws| line as well.

Comment 2

[Steven MacLeod [:smacleod]]

Comment on attachment 8465594 [details] [diff] [review]
Remove calls to _ensureInitialized() (version 1)

Review of attachment 8465594 [details] [diff] [review]:
-----------------------------------------------------------------

Hey Tyler, this looks great. Thanks for the patch! I've pushed it to Try for you[1].

You should consider applying for Level 1 Commit access[2] so that you can push
to Try as well. Tim or I would vouch for you.

Please let me know if you'd like any help finding more stuff to work on.

Thanks!

[1] https://tbpl.mozilla.org/?tree=Try&rev=5a00ca10c01c
[2] https://www.mozilla.org/hacking/commit-access-policy/

Comment 3

[Steven MacLeod [:smacleod]]

If you'd like to apply for commit access you should also take a look at https://www.mozilla.org/hacking/committer/

Comment 4

[Steven MacLeod [:smacleod]]

Try looks fine.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/b8672944145a

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/b8672944145a