952233 - topcrasher_ranks_bybug should display "not found in topcrash lists" for rankless results

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Robert Helmer [:rhelmer]]

Results without rank are filtered in the template right now, so we can end up with signatures without any result when you open the twisty menu:

https://crash-stats.allizom.org/topcrasher_ranks_bybug/?bug_number=951860

Filtering should probably happen in the view instead so these just don't appear in the template at all.

Comment 1

[Robert Kaiser]

It would be confusing if the signature doesn't show up at all, but we should display a line that says it cannot be found in any topcrash lists at this time.

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to Robert Kaiser (:[e-mail]) from comment #1)
> It would be confusing if the signature doesn't show up at all, but we should
> display a line that says it cannot be found in any topcrash lists at this
> time.

Good call - will leave this in the template in that case, but display a message.

As an aside, I wonder if it really makes sense to have these all collapsed by default? Seems like a hassle.

Comment 3

[Robert Kaiser]

(In reply to Robert Helmer [:rhelmer] from comment #2)
> As an aside, I wonder if it really makes sense to have these all collapsed
> by default? Seems like a hassle.

I agree, having them expanded by default is probably a better experience.

Comment 4

[Robert Helmer [:rhelmer]]

Attachment: expand results by default

Comment 5

[Robert Helmer [:rhelmer]]

Attachment: display warning message for rankless results

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/e4eb493c4aee5babebb1a2a2d4de8260d2ff33d2
bug 952233 - expand topcrasher_ranks_bybug results by default

https://github.com/mozilla/socorro/commit/621fbac897df9f47156d3939c903e4580395b0dd
Merge pull request #1827 from rhelmer/bug952233-expand-topcrasher_ranks_bybug-by-default

bug 952233 - expand topcrasher_ranks_bybug results by default

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/81a63b48728c1f2e86235166c089e39898c3b2b7
fixes bug 952233 - display message if signature not in active releases

https://github.com/mozilla/socorro/commit/d3840997cb21f4cbf187171bb5d69f728d09af36
Merge pull request #1828 from rhelmer/bug952233-display-message-if-no-active-releases

Bug952233 display message if no active releases