Closed Bug 952330 Opened 8 years ago Closed 8 years ago

Synchronize updates to global object slots

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: bhackett1024, Assigned: bhackett1024)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch patchSplinter Review
Some global object dynamically allocated reserved slots are read from off thread during IonBuilder (e.g. builtin class constructors), so the global object's slots need to be protected by the compilation lock.  Bug 785905 made a note of this but I forgot to actually add the synchronization code.
Attachment #8350391 - Flags: review?(jdemooij)
Comment on attachment 8350391 [details] [diff] [review]
patch

Review of attachment 8350391 [details] [diff] [review]:
-----------------------------------------------------------------

Good find..
Attachment #8350391 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/226af3342987
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.