Closed Bug 952401 Opened 12 years ago Closed 12 years ago

Scroll position isn't restored after reloading a scrolled page

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Version:
29 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 29
Tracking Flags:
Tracking Status
firefox29 --- affected

People

(Reporter: alice0775, Assigned: ttaubert)

References

Details

(Keywords: regression, reproducible, Whiteboard: [good first verify])

Attachments

(1 file)

0001-Bug-952401-Collect-scroll-and-pageStyle-data-as-soon.patch
2.88 KB, patch
smacleod
: review+
Details | Diff | Splinter Review
@BenYeeHua reprted in http://forums.mozillazine.org/viewtopic.php?p=13262375#p13262375 Steps to reproduce: 1. Open http://forums.mozillazine.org/viewforum.php?f=23 2. Scroll to any place 3. Click F5 to Reload 4. Restart Browser 5. Click "Restore Previous Session" Actual results: Scroll position is lost. It forgot where it should be, after reload. Expected results: It should remember where it should be, after reload Regression window(m-c) Good: http://hg.mozilla.org/mozilla-central/rev/940c52e93281 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20131218181509 Bad: http://hg.mozilla.org/mozilla-central/rev/04a70c8908de Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20131218182005 Pushlog http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=940c52e93281&tochange=04a70c8908de Regression window(fx) Good: http://hg.mozilla.org/integration/fx-team/rev/997deec5970a Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20131218112628 Bad: http://hg.mozilla.org/integration/fx-team/rev/b42216b98522 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20131218122258 Pushlog http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=997deec5970a&tochange=b42216b98522 Regressed by: Bug 921942
Severity: normal → major
tracking-firefox29: ? → ---
Summary: Scroll position isn't restored after session restore → Scroll position isn't restored after reloading a scrolled page
Severity: major → normal
OS: Windows 7 → All
Hardware: x86_64 → All
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
When reloading a larger page with resources (not a small test file) shistory restores the scroll position before the page has loaded and we ignore the early scroll event. We should thus collect this type of the data when the frame tree is available. Also I fixed a little boo-boo.
Attachment #8350555 - Flags: review?(smacleod)
Attachment #8350555 - Flags: review?(smacleod) → review+
https://hg.mozilla.org/mozilla-central/rev/a04845059709
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
Whiteboard: [good first verify]
I cannot reproduce the problem anymore in Nightly30.0a1 as well as Aurora29.0a2. https://hg.mozilla.org/mozilla-central/rev/626d99c084cb Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140226030202 https://hg.mozilla.org/releases/mozilla-aurora/rev/2d1f9c800085 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20140226004001
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: