Closed
Bug 952462
Opened 12 years ago
Closed 12 years ago
Fix rooting hazard in Shape::dump()
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
DUPLICATE
of bug 952551
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
|
3.44 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Change Shape::dump() to disallow GC. This is never called directly but is useful for debugging purposes I guess.
It used to be called from PropertyTree::dumpShapes(), but the guts of have been left commented out for the last two years, so let's just remove this.
Attachment #8350593 -
Flags: review?(sphink)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 8350593 [details] [diff] [review]
shape-dump-hazard
Review of attachment 8350593 [details] [diff] [review]:
-----------------------------------------------------------------
Fine with me to remove it, given that you added it in the first place. But I don't see any connection between Shape::dump (in the title and comment 0) and PropertyTree::dumpShapes.
Oh well.
Attachment #8350593 -
Flags: review?(sphink) → review+
|
||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•