Closed Bug 952473 Opened 6 years ago Closed 6 years ago

SessionStore should only watch for top-level pageshow events

Categories

(Firefox for Android :: General, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 29
Tracking Status
firefox27 --- fixed
firefox28 --- fixed
firefox29 --- fixed

People

(Reporter: mfinkle, Assigned: mfinkle)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Desktop and Metro both limit the pagshow event to top-level windows/documents. We used to when we created the session store code Metro now uses. We lost it in the port.

I noticed this because SessionStore.onTabLoad was showing up in cnn.com pageload profiles.
Attachment #8350615 - Flags: review?(wjohnston)
Attachment #8350615 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/659ceeeb6ff9
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Blocks: 947390
Comment on attachment 8350615 [details] [diff] [review]
Top-level pageshow only v0.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Reduces the amount of times session is saved during a pageload. It should only happen once, but without this patch it can happen for iframes too.

User impact if declined: Just a possible performance issue.
Testing completed (on m-c, etc.): It's been on m-c for a while
Risk to taking this patch (and alternatives if risky): Low risk
String or IDL/UUID changes made by this patch: None
Attachment #8350615 - Flags: approval-mozilla-beta?
Attachment #8350615 - Flags: approval-mozilla-aurora?
Attachment #8350615 - Flags: approval-mozilla-beta?
Attachment #8350615 - Flags: approval-mozilla-beta+
Attachment #8350615 - Flags: approval-mozilla-aurora?
Attachment #8350615 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.