Closed Bug 952519 Opened 11 years ago Closed 7 years ago

[Messages][Drafts] Save invalid recipients to draft

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: julienw, Unassigned)

References

Details

Attachments

(1 file)

STR:
* open "new message" view
* add invalid recipients (eg: "abc")
* press back
* save draft
* recall the newly created draft

Expected:
* the invalid recipient "abc" is here

Actual:
* it's not here

In the thread list, I think we should see that recipient too, but let's ask confirmation to Ayman.
Flags: needinfo?(aymanmaat)
Assignee: nobody → waldron.rick
Summary: [Messages][Drafts] Invalid recipients don't get saved in drafts → [Messages][Drafts] Save invalid recipients to draft
Comment on attachment 8364403 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15651

Recalling doesn't work properly, so removing my review flag.

The code looks ok though.
Attachment #8364403 - Flags: review?(felash)
FTR I left some comments yesterday on github.
Comment on attachment 8364403 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15651

Removing my review request to clean up my queue, please request review again once you're ready.

I found another issue with the current patch: when sending a MMS to several recipients, it's sent to the first one only. Probably related to the "numbers" small refactoring.
Attachment #8364403 - Flags: review?(felash)
triage: move this to 1.5?
blocking-b2g: 1.4? → 1.5?
to backlog
blocking-b2g: 1.5? → backlog
Depends on: 1015194
This was fixed in the v1.3t branch only in bug 989600 and bug 1011573. Should not be difficult to retrofit the fix here.
blocking-b2g: backlog → ---
Flags: needinfo?(aymanmaat)
Blocks: 1176976
No longer blocks: 1176976
Rick is likely busy with his own stuff :)
Assignee: waldron.rick → nobody
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Still valid.
Mass closing of Gaia::SMS bugs. End of an era :(
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Mass closing of Gaia::SMS bugs. End of an era :(
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: