Closed
Bug 952519
Opened 12 years ago
Closed 9 years ago
[Messages][Drafts] Save invalid recipients to draft
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: julienw, Unassigned)
References
Details
Attachments
(1 file)
STR:
* open "new message" view
* add invalid recipients (eg: "abc")
* press back
* save draft
* recall the newly created draft
Expected:
* the invalid recipient "abc" is here
Actual:
* it's not here
In the thread list, I think we should see that recipient too, but let's ask confirmation to Ayman.
Flags: needinfo?(aymanmaat)
|
||
Updated•12 years ago
|
Assignee: nobody → waldron.rick
|
|
||
Updated•12 years ago
|
Summary: [Messages][Drafts] Invalid recipients don't get saved in drafts → [Messages][Drafts] Save invalid recipients to draft
|
|
||
Comment 1•12 years ago
|
||
Attachment #8364403 -
Flags: review?(felash)
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 8364403 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15651
Recalling doesn't work properly, so removing my review flag.
The code looks ok though.
Attachment #8364403 -
Flags: review?(felash)
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 8364403 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15651
Ready for another round!
Attachment #8364403 -
Flags: review?(felash)
|
|
Reporter | |
Comment 4•12 years ago
|
||
FTR I left some comments yesterday on github.
|
|
Reporter | |
Comment 5•12 years ago
|
||
Comment on attachment 8364403 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15651
Removing my review request to clean up my queue, please request review again once you're ready.
I found another issue with the current patch: when sending a MMS to several recipients, it's sent to the first one only. Probably related to the "numbers" small refactoring.
Attachment #8364403 -
Flags: review?(felash)
|
|
Reporter | |
Comment 8•11 years ago
|
||
This was fixed in the v1.3t branch only in bug 989600 and bug 1011573. Should not be difficult to retrofit the fix here.
|
Assignee | |
Updated•11 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
|
||
Updated•11 years ago
|
tracking-b2g:
backlog → ---
Flags: needinfo?(aymanmaat)
|
||
Updated•11 years ago
|
Blocks: sms-drafts
|
|
||
Comment 9•10 years ago
|
||
Rick is likely busy with his own stuff :)
Assignee: waldron.rick → nobody
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
|
|
Reporter | |
Comment 10•10 years ago
|
||
Still valid.
|
|
Reporter | |
Comment 11•9 years ago
|
||
Mass closing of Gaia::SMS bugs. End of an era :(
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
|
|
Reporter | |
Comment 12•9 years ago
|
||
Mass closing of Gaia::SMS bugs. End of an era :(
You need to log in
before you can comment on or make changes to this bug.
Description
•