952693 - The Nuwa process should never be OOM killed

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

We should never OOM kill the Nuwa process while any app processes are alive, because then there will be app processes spawned from multiple Nuwa template processes, defeating some of the optimization.  Since the Nuwa process should be low overhead, I think we should consider even killing the parent process first.

Comment 1

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: bug-952693.patch

Hi, Kyle, When I try nuwa on device with 128MB memory, I used to adjust nuwa process's priority to the same as parent process in order to prevent it'd been killed by LMK. But I am not sure if this method is a good solution.

Comment 2

[Thinker Li [:sinker]]

Bug 957509 would reduce the size of USS of Nuwa to 1.xMB and preallocated process to 0.8MB.  The overhead of Nuwa was dramatically drop.

Comment 3

[Kai-Chih Hu [:khu]]

(In reply to Thinker Li [:sinker] from comment #2)
> Bug 957509 would reduce the size of USS of Nuwa to 1.xMB and preallocated
> process to 0.8MB.  The overhead of Nuwa was dramatically drop.

Sounds good! Then, are we going to land Kai-Zhen's patch as well? 
The patch looks like a good solution.

Comment 4

[Thinker Li [:sinker]]

He have applied the patch from cervantes for daily build.

Comment 5

[Kai-Chih Hu [:khu]]

Great. Can Kai-Zhen be the assignee for this bug to make sure this bug already has owner and progress? Thank you.

Comment 6

[Kai-Zhen Li [:seinlin][:kli]]

I think we can get the attached patch reviewed and landed. But it depends on bug 950266. Before bug 950266 got fix nuwa is not enabled in b2g by default.

Comment 7

[Kai-Chih Hu [:khu]]

Thanks. I think it's a good approach. Can you mark review? to ask for review? Thanks.

Comment 8

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/b5de6c59aff2

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b5de6c59aff2

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/03ae7f855491