Closed Bug 952693 Opened 6 years ago Closed 6 years ago

The Nuwa process should never be OOM killed

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29
blocking-b2g 1.3+
Tracking Status
firefox27 --- wontfix
firefox28 --- fixed
firefox29 --- fixed
b2g-v1.3 --- fixed
b2g-v1.4 --- fixed

People

(Reporter: khuey, Assigned: seinlin)

References

Details

Attachments

(1 file)

We should never OOM kill the Nuwa process while any app processes are alive, because then there will be app processes spawned from multiple Nuwa template processes, defeating some of the optimization.  Since the Nuwa process should be low overhead, I think we should consider even killing the parent process first.
Attached patch bug-952693.patchSplinter Review
Hi, Kyle, When I try nuwa on device with 128MB memory, I used to adjust nuwa process's priority to the same as parent process in order to prevent it'd been killed by LMK. But I am not sure if this method is a good solution.
Attachment #8350975 - Flags: feedback?(khuey)
Attachment #8350975 - Flags: feedback?(khuey) → feedback+
blocking-b2g: 1.3? → 1.3+
Bug 957509 would reduce the size of USS of Nuwa to 1.xMB and preallocated process to 0.8MB.  The overhead of Nuwa was dramatically drop.
(In reply to Thinker Li [:sinker] from comment #2)
> Bug 957509 would reduce the size of USS of Nuwa to 1.xMB and preallocated
> process to 0.8MB.  The overhead of Nuwa was dramatically drop.

Sounds good! Then, are we going to land Kai-Zhen's patch as well? 
The patch looks like a good solution.
Flags: needinfo?(tlee)
He have applied the patch from cervantes for daily build.
Flags: needinfo?(tlee)
Great. Can Kai-Zhen be the assignee for this bug to make sure this bug already has owner and progress? Thank you.
Flags: needinfo?(kli)
I think we can get the attached patch reviewed and landed. But it depends on bug 950266. Before bug 950266 got fix nuwa is not enabled in b2g by default.
Flags: needinfo?(kli)
Thanks. I think it's a good approach. Can you mark review? to ask for review? Thanks.
Attachment #8350975 - Flags: review?(khuey)
Attachment #8350975 - Flags: review?(khuey) → review+
https://hg.mozilla.org/mozilla-central/rev/b5de6c59aff2
Assignee: nobody → kli
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.