952741 - Mochitest for Keyboard/IME API to test focused element deletion

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Yuan Xulei [:yxl] (Leave from May 18)]

We need a mochitest test for bug 902942. It fixed the issue that when the focused input element is removed, the keyboard cannot be notified and hidden. The patch of 902942 has a side effect that cause bug 914100. The new test must ensure the side effect is removed.

Comment 1

[Yuan Xulei [:yxl] (Leave from May 18)]

Attachment: patch v1

https://tbpl.mozilla.org/?tree=Try&rev=3412ecb1adaa

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 8350892 [details] [diff] [review]
patch v1

Review of attachment 8350892 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

::: dom/inputmethod/mochitest/test_delete_focused_element.html
@@ +53,5 @@
> +    mm.addMessageListener("test:InputMethod:finished", function() {
> +      timeoutId = setTimeout(function() {
> +        ok(false, 'No inputcontextchange event when textarea is deleted.');
> +        inputmethod_cleanup();
> +      }, 60000);

That's a really long timeout. I'd be happier if we tuned that down to something between 10s and 30s for instance.

Comment 3

[Yuan Xulei [:yxl] (Leave from May 18)]

Attachment: mochitest v2

Fabrice, thank you. The patch changes the timeout to 20s.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/fd46c37a74f1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fd46c37a74f1