Closed
Bug 952741
Opened 11 years ago
Closed 11 years ago
Mochitest for Keyboard/IME API to test focused element deletion
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Firefox OS Graveyard
Gaia::Keyboard
Tracking
(Not tracked)
RESOLVED
FIXED
1.3 C2/1.4 S2(17jan)
People
(Reporter: xyuan, Assigned: xyuan)
References
Details
Attachments
(1 file, 1 obsolete file)
3.83 KB,
patch
|
xyuan
:
review+
|
Details | Diff | Splinter Review |
We need a mochitest test for bug 902942. It fixed the issue that when the focused input element is removed, the keyboard cannot be notified and hidden. The patch of 902942 has a side effect that cause bug 914100. The new test must ensure the side effect is removed.
Assignee | ||
Comment 1•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=3412ecb1adaa
Attachment #8350892 -
Flags: review?(fabrice)
Comment 2•11 years ago
|
||
Comment on attachment 8350892 [details] [diff] [review] patch v1 Review of attachment 8350892 [details] [diff] [review]: ----------------------------------------------------------------- thanks! ::: dom/inputmethod/mochitest/test_delete_focused_element.html @@ +53,5 @@ > + mm.addMessageListener("test:InputMethod:finished", function() { > + timeoutId = setTimeout(function() { > + ok(false, 'No inputcontextchange event when textarea is deleted.'); > + inputmethod_cleanup(); > + }, 60000); That's a really long timeout. I'd be happier if we tuned that down to something between 10s and 30s for instance.
Attachment #8350892 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Fabrice, thank you. The patch changes the timeout to 20s.
Attachment #8350892 -
Attachment is obsolete: true
Attachment #8356414 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/fd46c37a74f1
Flags: in-testsuite+
Keywords: checkin-needed
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fd46c37a74f1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C2/1.4 S2(17jan)
You need to log in
before you can comment on or make changes to this bug.
Description
•