If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove all style="..." attributes from HTML elements

RESOLVED FIXED in Bugzilla 5.0

Status

()

Bugzilla
User Interface
--
enhancement
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

4.5.1
Bugzilla 5.0
Dependency tree / graph
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
<foo style="..."> should be replaced by CSS rules.
(Assignee)

Comment 1

4 years ago
Created attachment 8351205 [details] [diff] [review]
patch, v1

style="..." is still in use in email/bugmail.html.tmpl because CSS rules must be included with the bugmails, and it's also in use in search/boolean-charts.html.tmpl to indent rows correctly depending on the AND/OR combinations. As there is no limit in the number of AND/OR you can use, we cannot hardcode the list in CSS files. All other style="..." have been removed.
Assignee: ui → LpSolit
Status: NEW → ASSIGNED
Attachment #8351205 - Flags: review?(justdave)
Comment on attachment 8351205 [details] [diff] [review]
patch, v1

Looks good, I don't see any issues.
Attachment #8351205 - Flags: review?(justdave) → review+
Flags: approval+
(Assignee)

Comment 3

4 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified skins/standard/admin.css
modified skins/standard/dependency-tree.css
modified skins/standard/editusers.css
modified skins/standard/global.css
modified skins/standard/reports.css
modified skins/standard/summarize-time.css
modified template/en/default/admin/table.html.tmpl
modified template/en/default/admin/flag-type/edit.html.tmpl
modified template/en/default/admin/params/common.html.tmpl
modified template/en/default/admin/params/general.html.tmpl
modified template/en/default/admin/products/updated.html.tmpl
modified template/en/default/admin/users/edit.html.tmpl
modified template/en/default/attachment/diff-file.html.tmpl
modified template/en/default/attachment/diff-header.html.tmpl
modified template/en/default/bug/dependency-tree.html.tmpl
modified template/en/default/bug/summarize-time.html.tmpl
modified template/en/default/bug/create/create-guided.html.tmpl
modified template/en/default/flag/list.html.tmpl
modified template/en/default/global/textarea.html.tmpl
modified template/en/default/list/edit-multiple.html.tmpl
modified template/en/default/list/server-push.html.tmpl
modified template/en/default/list/table.html.tmpl
modified template/en/default/reports/create-chart.html.tmpl
modified template/en/default/reports/edit-series.html.tmpl
modified template/en/default/reports/series-common.html.tmpl
modified template/en/default/reports/series.html.tmpl
modified template/en/default/search/search-create-series.html.tmpl
modified template/en/default/whine/schedule.html.tmpl
Committed revision 8841.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Blocks: 301384
You need to log in before you can comment on or make changes to this bug.