952936 - Use CAF's platform/system/core's repository to make B2G binaries executable

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect)

Description

[:gerard-majax]

To produce valid FOTA packages, we need to augment the permissions defined in Android. This is already done in https://github.com/mozilla-b2g/platform_system_core/commit/542d1f59dc331b472307e5bd043101d14d5a3a3e.

Comment 1

[:gerard-majax]

This commit is not in the master branch of the repository.

Comment 2

[:gerard-majax]

Code Aurora's repo has it:

commit b04108af99dd58340fea878079640bc4943e6b3e
Author: Indrajeet Kumar <[e-mail]>
Date:   Fri Sep 20 08:21:48 2013 -0700

    filesystem_config: Mark /system/b2g programs executable
    
    Change-Id: Ie1f6d079214da7acc0c8f776db24b6465a12d1c9

diff --git a/include/private/android_filesystem_config.h b/include/private/android_filesystem_config.h
index 8289561..3139d9f 100755
--- a/include/private/android_filesystem_config.h
+++ b/include/private/android_filesystem_config.h
@@ -180,6 +180,9 @@ static struct fs_path_config android_dirs[] = {
 ** and will allow partial matches.
 */
 static struct fs_path_config android_files[] = {
+    { 00775, AID_ROOT,      AID_ROOT,      "system/b2g/b2g" },
+    { 00775, AID_ROOT,      AID_ROOT,      "system/b2g/updater" },
+    { 00775, AID_ROOT,      AID_ROOT,      "system/b2g/plugin-container" },
     { 00440, AID_ROOT,      AID_SHELL,     "system/etc/init.goldfish.rc" },
     { 00550, AID_ROOT,      AID_SHELL,     "system/etc/init.goldfish.sh" },
     { 00550, AID_ROOT  ,    AID_SYSTEM,    "system/etc/init.qcom.sdio.sh" },
alex@portable-alex:~/codaz/Mozilla/b2g/caf_hamachi_platform_system_core$

Comment 3

[:gerard-majax]

Attachment: Link to Github https://github.com/mozilla-b2g/b2g-manifest/pull/126

Please find attached a link to the github pull request that makes use of b2g_ics_1.2 revision for ICS-based devices.

After applying and testing for Inari, the updater-script contains the correct permissions for a FOTA package built:
set_perm_recursive(0, 0, 0755, 0644, "/system/b2g");
set_perm(0, 0, 0775, "/system/b2g/b2g");
set_perm(0, 0, 0775, "/system/b2g/plugin-container");
set_perm(0, 0, 0775, "/system/b2g/updater");

Comment 4

[Michael Wu [:mwu]]

b2g_ics_1.2 can *only* be used for CAF based devices. Devices which are inherently AOSP need a local fork, but we're not actually supporting any ICS devices based off AOSP.

Comment 5

[:gerard-majax]

(In reply to Michael Wu [:mwu] from comment #4)
> b2g_ics_1.2 can *only* be used for CAF based devices. Devices which are
> inherently AOSP need a local fork, but we're not actually supporting any ICS
> devices based off AOSP.

Aren't Leo and Inari CAF-based ?

Whatever the solution, we need to fix the header defining the permissions.

Comment 6

[Michael Wu [:mwu]]

Yeah. In general, commercial devices can take this update, nexus and emulator can not.

Comment 7

[:gerard-majax]

(In reply to Michael Wu [:mwu] from comment #6)
> Yeah. In general, commercial devices can take this update, nexus and
> emulator can not.

Since we are not supporting Nexus devices and that producing updates for the emulator does not make a lot of sense, that should be okay.